GithubHelp home page GithubHelp logo

Comments (17)

bwp91 avatar bwp91 commented on June 9, 2024

Hi @kaduffey could you update to the beta version of the plugin?
Currently the only difference between the version you are running and the beta version is that it will show more detailed entries in the homebridge log.
I really need to see homebridge logs when you are expecting the home app to shout an alert when it isn't currently.
Could you update to the beta and kindly ask your wife to take a long shower and show me all the logs that appear?

from homebridge-flume.

kaduffey avatar kaduffey commented on June 9, 2024

from homebridge-flume.

bwp91 avatar bwp91 commented on June 9, 2024

ah there is a wiki link here to help 🙂
https://github.com/bwp91/homebridge-flume/wiki/Beta-Version

from homebridge-flume.

kaduffey avatar kaduffey commented on June 9, 2024

from homebridge-flume.

kaduffey avatar kaduffey commented on June 9, 2024

from homebridge-flume.

kaduffey avatar kaduffey commented on June 9, 2024

from homebridge-flume.

kaduffey avatar kaduffey commented on June 9, 2024

from homebridge-flume.

bwp91 avatar bwp91 commented on June 9, 2024

Hi @kaduffey

Please can you (1) change your flume password, (2) update to the new version and (3) let me know when you have done this?

from homebridge-flume.

kaduffey avatar kaduffey commented on June 9, 2024

from homebridge-flume.

bwp91 avatar bwp91 commented on June 9, 2024

I advised because your logs contains credentials to allow anyone to log into your account.
The new version redacts this data.
This is why i asked for you to tell me when done

from homebridge-flume.

kaduffey avatar kaduffey commented on June 9, 2024

from homebridge-flume.

kaduffey avatar kaduffey commented on June 9, 2024

from homebridge-flume.

bwp91 avatar bwp91 commented on June 9, 2024

hanged, and homebridge restarted with new PWD for Flume You should never be capturing passwords or userid's (client IDs, secrets etc in log). PLease auto redact those or dont log them at all

Yes thank you. I am aware and this why i released a new version of the plugin which does redact this.

I do not own any flume devices but took this plugin on with best intentions

from homebridge-flume.

bwp91 avatar bwp91 commented on June 9, 2024

Your comments have made me realise that I am probably not ideal as a maintainer of this plugin.

Have made a request for this plugin to be pushed to the unmaintained plugins section of Homebridge, and hopefully, someone better equipped can take it over!

from homebridge-flume.

kaduffey avatar kaduffey commented on June 9, 2024

from homebridge-flume.

kaduffey avatar kaduffey commented on June 9, 2024

I dont think you should give up. Your response is great, and you fixed what I mentioned. Sorry if I came across strong. Happy to be your tester on my flume. Do they use Flume in England?

from homebridge-flume.

kaduffey avatar kaduffey commented on June 9, 2024

Looked at this again, and I think I saw the icon flash on/off - I turned off water right after I got the flume based alert? Could it be its only on when the 'leak' is active and doesnt leave a persistent alert? Or perhaps I dont wait long enough for your polling of flume to occur?

from homebridge-flume.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.