Root span never closed if status code is 500 about beeline-python

[MatthewMiele]

I've just run into what seems to be the same issue. It looks like the problem is with this line

beeline-python/beeline/middleware/flask/__init__.py

Line 51 in 7c5268e

elif status_code == 500 and not signals.signals_available:

specifically the signals check and not signals.signals_available.
for me signals.signals_available is True.

For signals to work in Flask you need a library called blinker. When I remove blinker, signals.signals_available becomes False and my error spans are restored.

I think the real bug might lie in this file / with how Honeycomb is using signals?

beeline-python/beeline/middleware/flask/__init__.py

Lines 18 to 19 in 7c5268e

	if signals.signals_available:
	self.app.teardown_request(self._teardown_request)

specifically in this function

beeline-python/beeline/middleware/flask/__init__.py

Lines 27 to 33 in 7c5268e

	def _teardown_request(self, exception):
	if exception:
	beeline.add_field('request.error_detail',
	beeline.internal.stringify_exception(exception))
	beeline.add_field('request.error', str(type(exception)))
	beeline.internal.send_event()

It seems like it adds a callback for Flask signals to call at the end of the request but for me the exception that is being based in is None and I believe this is due to already being handled by my custom error handlers in Flask. By the time the code gets here there is no Exception, its now just a normal response object that is a 500 with some json.

Removing all my custom error handlers (and running flask locally not in development mode - to stop flasks built in error handler) the error spans also reappear - this time with blinker installed