Comments (6)
@c4milo @wmertens @atoy40 @wmertens @tralamazza anyone else I forgot? 😄
from node-libvirt.
I'm ok with either, and would lean towards one or the other based on effort.
from node-libvirt.
@Rush actually did a little napkin implementation when we were talking about it that supports callbacks and promises, so the effort is pretty minimal either way - it's more an issue of preference afaict. I feel like considering we attempt to follow semver, now is the time to discuss API breaks etc
from node-libvirt.
I see, I think it is nice to be backwards compatible, especially, since we don't really know how many people is using the library. However, based on the NPM stats, it seems very few are.
from node-libvirt.
I think having the missing callback trigger promise creation is great, so that either option is available. Very little overhead.
The NPM stats are probably low because this is a very niche product, how many people are writing tools in this space? Myself, I'm no longer in the job I was using this in :)
from node-libvirt.
Hello, I only use the Promisified API (through GraphQL schema/resolvers), but I feel supporting both callbacks and promises is the best way to do.
from node-libvirt.
Related Issues (20)
- Parent objects get garbage collected before children' async operations finish which can lead to a crash HOT 3
- Error information can be lost during high concurrency
- Error objects become invalid and cause a crash (test-case supplied) HOT 7
- lookupStorageVolumeByVolume is not implemented HOT 4
- tests != docs. HOT 6
- Events not firing HOT 6
- list by domain name? HOT 6
- Error with connection pointers HOT 4
- Domain migration with options fails with sigfault HOT 1
- lookupDomainByUUID HOT 3
- set/get secret value do not work properly HOT 4
- Domain clonage
- npm install in windows error
- Current version in npm does not have the latest fixes. HOT 6
- How to listen for all domain events from hypervisor
- Maintainers? HOT 3
- Crashes when using events
- Can't install on Centos 7
- Is this library relevant?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-libvirt.