v2.0.0 promisification changes about node-libvirt

[mbroadst]

@c4milo @wmertens @atoy40 @wmertens @tralamazza anyone else I forgot? 😄

[c4milo]

I'm ok with either, and would lean towards one or the other based on effort.

[mbroadst]

@Rush actually did a little napkin implementation when we were talking about it that supports callbacks and promises, so the effort is pretty minimal either way - it's more an issue of preference afaict. I feel like considering we attempt to follow semver, now is the time to discuss API breaks etc

[c4milo]

I see, I think it is nice to be backwards compatible, especially, since we don't really know how many people is using the library. However, based on the NPM stats, it seems very few are.

[wmertens]

I think having the missing callback trigger promise creation is great, so that either option is available. Very little overhead.

The NPM stats are probably low because this is a very niche product, how many people are writing tools in this space? Myself, I'm no longer in the job I was using this in :)

[atoy40]

Hello, I only use the Promisified API (through GraphQL schema/resolvers), but I feel supporting both callbacks and promises is the best way to do.