Reciprocal friendship about laravel-friendships

[hootlex]

Hello Robin,
It should work this way. I will check it out.

[hootlex]

As I can see this is the default behaviour of a Friendship.

For example:

$sender = createUser();
$recipient = createUser();

$sender->befriend($recipient);
$recipient->acceptFriendRequest($sender);

//Result
$recipient->isFriendWith($sender); //true
$sender->isFriendWith($recipient); //true

Now $sender->getAcceptedFriendships() returns

Illuminate\Database\Eloquent\Collection {#982
     all: [
       Hootlex\Friendships\Models\Friendship {#984
         id: 66,
         sender_id: 11,
         sender_type: "App\User",
         recipient_id: 12,
         recipient_type: "App\User",
         status: 1,
         created_at: "2016-01-15 01:46:18",
         updated_at: "2016-01-15 01:46:20",
       },
     ],
   }

And $recipiend->getAcceptedFriendships() returns the same

Illuminate\Database\Eloquent\Collection {#982
     all: [
       Hootlex\Friendships\Models\Friendship {#984
         id: 66,
         sender_id: 11,
         sender_type: "App\User",
         recipient_id: 12,
         recipient_type: "App\User",
         status: 1,
         created_at: "2016-01-15 01:46:18",
         updated_at: "2016-01-15 01:46:20",
       },
     ],
   }

[RosiersRobin]

So, how would I be able to display everything and check if the persons are already friends?

Also, I'm trying to use the package in this way:

User::find(Auth::id())->isFriendWith($userdata->UID) wich should be rendered something like this:
User::find(18)->isFriendWith(4).

But that gives me the following error:
Argument 1 passed to User::isFriendWith() must be an instance of Illuminate\Database\Eloquent\Model, integer given

Yes, I included the package in the user model:

use Hootlex\Friendships\Traits\Friendable;

class User extends Model implements AuthenticatableContract, CanResetPasswordContract, HasRoleAndPermissionContract
{
    use Authenticatable, CanResetPassword, HasRoleAndPermission, Friendable;
...

Can this be a issue? Or how should I handle the package (in my view)?

[hootlex]

The isFriendWith expects a model as a parameter not an integer. In order to check if two users are friends you have to use it this way:

User::find(18)->isFriendWith(User::find(4))

[hootlex]

I will implement a getFriends method which will return all User friends instead of returning Friendship objects.

[RosiersRobin]

It worked. Could you maybe also implement a function that checks if a user has a pending request of another user?

Something like

User::find(Auth::id())->isPendingFriend(User::find($userdata->UID))

The Auth returns the current user id and the $userdata->UID is the ID of the users profile i'm watching on.
This would be handy for me like if a users has a pending request, of user X, I can display a cancel button to cancel the request.

[hootlex]

Checking friendship status between two users can be easily done via getFriendship().

example:

$friendship = $sender->getFriendship($recipient)
if($friendship->status == Status::PENDING){
    //your code
}

$friendship is an instance of Friendship.

Hootlex\Friendships\Models\Friendship {#962
     id: 333,
     sender_id: 441,
     sender_type: "App\User",
     recipient_id: 445,
     recipient_type: "App\User",
     status: 0,
     created_at: "2016-01-16 01:36:08",
     updated_at: "2016-01-16 01:36:08",
   }

[RosiersRobin]

I found something else (made some new code in your package).

But when I try to count how many friends someone has, it returns 1 already on the requested friend.

So Current friends: User A: 0 User B: 0.

When user B request a friendship to user A, User A has 1 friend (not accepted yet) and user B has 0 friends. Code that I'm using:

User::find($userdata->UID)->getAcceptedFriendships()->count()

I don't know how I can use it in any other way?

[hootlex]

Maybe you are using an old version. This is fixed in v1.0.7.

Also I have added $user->getFriends() in v1.0.8!

[RosiersRobin]

Cool! Now this works like a charm! Thanks for adding my requested features! If you need any help, just give me a shout 😄

[hootlex]

Thanks! :)

[pkitatta]

Hi, can this system avoid duplicate rows of relationship. Example - can sender_id, recipient - 3,2 be stored as 2,3, so that makes 2 records for the same relationship.

[RosiersRobin]

Well if one row already exists, then you'll have a "friendship". But if there are two rows like you say (wich you can avoid in your project) will not affect the output.