GithubHelp home page GithubHelp logo

Comments (15)

ArslanM786 avatar ArslanM786 commented on May 21, 2024 1

Okay I will start working on replacing the links

from hospitalrun.io.

matteovivona avatar matteovivona commented on May 21, 2024 1

Point to first one

from hospitalrun.io.

ArslanM786 avatar ArslanM786 commented on May 21, 2024

Could I get a little clarification please? The links need to to be routed to the correct pages?

from hospitalrun.io.

matteovivona avatar matteovivona commented on May 21, 2024

It is a matter of replacing links in the code where possible or creating a rewriting rule (a core team task)

from hospitalrun.io.

ArslanM786 avatar ArslanM786 commented on May 21, 2024

Could I get added as an assignee for this issue please?

from hospitalrun.io.

ArslanM786 avatar ArslanM786 commented on May 21, 2024

I had a question, I noticed, according to the sheet, that there are multiple of the same exact broken links that are associated with different working links. For example the link https://www.hospitalrun.io/blog/2017/05/announcing-hospitalrun-1.0.0-beta is associated with https://www.hospitalrun.io/blog/ and also https://www.hospitalrun.io/blog/roadmap-to-hospitalrun-1.0/ in different instances. So it is unclear which link I replace it with.

from hospitalrun.io.

ArslanM786 avatar ArslanM786 commented on May 21, 2024

As I was trying to commit my changes to submit a PR, says no changes to commit. The files I changed by fixing the broken links does not show up as changes made. However changes made in the page folder show up as commits. I asked my mentor for help and since it's jekyll he said I have to find the corresponding files in pages files that correspond with the files i changes in the _site folder. But I do not see the corresponding files or the links I need to change. Is it possible to set up a quick and short zoom meeting when you have the time to look this over?

from hospitalrun.io.

matteovivona avatar matteovivona commented on May 21, 2024

can you give an example? files that you have modified including full path and line?

from hospitalrun.io.

ArslanM786 avatar ArslanM786 commented on May 21, 2024

For example some files I modified were hospitalrun.io/_site/blog/announcing-hospitalrun-1.0.0-beta/index.html line 437, hospitalrun.io/_site/tag/v2.0.0/index.html line 477 and 483, etc

from hospitalrun.io.

matteovivona avatar matteovivona commented on May 21, 2024

_site is a directory generated dynamically when code is built. you don't have to modify anything inside that directory. a site structure is described here https://github.com/HospitalRun/hospitalrun.io#directory-structure

from hospitalrun.io.

ArslanM786 avatar ArslanM786 commented on May 21, 2024

Okay I understand, that is why my changes can't be committed in that directory. But I checked all the files and _site directory is where the broken links that I need to replace links coded. Then I don't understand in which files I replace the links

from hospitalrun.io.

ArslanM786 avatar ArslanM786 commented on May 21, 2024

@tehKapa Any update on what I should do to resolve this problem I am having

from hospitalrun.io.

matteovivona avatar matteovivona commented on May 21, 2024

You have to look up where the addresses are generated. It's likely that many are generated dynamically and core team need to create rewrite rules (as written here)

from hospitalrun.io.

agusbrand avatar agusbrand commented on May 21, 2024

@tehKapa Could I take this?

from hospitalrun.io.

matteovivona avatar matteovivona commented on May 21, 2024

ok @agusbrand

from hospitalrun.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.