GithubHelp home page GithubHelp logo

Comments (2)

dvisockas avatar dvisockas commented on May 23, 2024 1

@cmartyn, after a weekend of digging found a rather hacky fix: remove 'turbo-stream;' from Content-Type headers:

if response.headers['Content-Type'].include? 'text/html'
  response.headers['Content-Type'].remove!('turbo-stream;')
end

from turbo-rails.

dhh avatar dhh commented on May 23, 2024

That's a good catch. It's caused by the need to switch rendering formats when streams are rendered, see

rendering.delete(:content) || (rendering.any? ? render_format(:html, **rendering) : nil)
. Can only force that switch if the mime type is present in the template.

Not sure the best way to catch/alert about this. Maybe there's a way to catch the exception in

def render_format(format, **rendering)
ApplicationController.render(formats: [ format ], **rendering)
end
and rethrow with better error messaging? Please do investigate!

from turbo-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.