HTTP Header Parsing in http4k after Upgrading to Version 5.13.7.0 about http4k

[beleagaalexandra]

Thank you for you response! We'll work around on that

[daviddenton]

I think this will be due to the change made to the jetty backend which splits headers with quotes in them:
#1023

[beleagaalexandra]

Ah, ok. I see.
Then, is this the desired behaviour? I understand that the issue with loosing quotes has been fixed.

[s4nchez]

@beleagaalexandra can you please provide a snippet creating a Request object with the problematic data (setting the header with your expected quotes/escaping) so we can write a test for it?

[beleagaalexandra]

In order to intercept the incoming requests, we have a routing http handler and we are also using a filter for parsing the header, but when getting to the parser in the filter, the header is already split.

typealias CustomControl = Map<String, JsonNode>
private object CustomControlHolder : RequestScoped<CustomControl>()
private val mapper = jacksonObjectMapper().configure(JsonParser.Feature.INCLUDE_SOURCE_IN_LOCATION, true)
object CaptureCustomControlHeaderFilter {
  private fun parse(json: String): CustomControl? =
      try {
        val node = mapper.readTree(json)
        node.fields().asSequence().associate { (k, v) -> k to v }
      } catch (e: JsonParseException) {
        null
      }
  private val customControlHeader = Header.map(::parse).optional("xxx-Header")
  operator fun invoke(): Filter = Filter { next ->
    { request ->
      try {
        val customControl = customControlHeader(request)
        if (customControl != null) {
          CustomControlHolder.add(customControl)
        }
        next(request)
      } finally {
        CustomControlHolder.clear()
      }
    }
  }
}

[s4nchez]

@beleagaalexandra we can confirm that this behaviour changed from Jetty 11 to 12.

Unfortunately, that splitting happens before http4k is involved, so your options here are either downgrade to jetty11 (by switching to the http4k-server-jetty11 module) or switch to another server implementation.