GithubHelp home page GithubHelp logo

Comments (5)

bryce-anderson avatar bryce-anderson commented on June 23, 2024

I agree, and this is something I've been meaning to add, but haven't gotten around to it as I've been preoccupied with implementing swagger support. I think this is also related tangentially to commit 175f877 in that we have the unnamed the concept of a "TypedBuilder" which carries chunks of AST along with the static type that they correspond to. I'd like to add something along the lines of TypedStatusLine for the path and query, and also an underlying trait which all those "builders" extend. The trait RouteExecutable[T <: HList] almost fills this role except for the method property.
I'll get to this soon (today or maybe tomorrow, but almost certainly by the end of the week), or you can feel free to take a crack at it. Just let me know if you do so we both don't write the same code.

from rho.

arouel avatar arouel commented on June 23, 2024

If I analyzed it correctly we need to merge the builders (e.g. PathBuilder, QueryBuilder) into a single one. Right?

from rho.

bryce-anderson avatar bryce-anderson commented on June 23, 2024

No, not necessarily. The reason they are different right now is that we
want to enforce the order of building up the route such that one cannot add
more path after you've started adding query elements. This could add
confusion to the method signature in the action function. However, if we
want to relax that requirement, we can merge them.
The thing I wanted to point out is that they both fall under a pattern were
we have a typed container that simply holds elements of the ASTs. I have
the itch to give that a name (trait), but its not strictly necessary.

On Mon, Jul 7, 2014 at 11:30 AM, André Rouél [email protected]
wrote:

If I analyzed it correctly we need to merge the builders (e.g. PathBuilder,
QueryBuilder) into a single one. Right?


Reply to this email directly or view it on GitHub
#9 (comment).

from rho.

bryce-anderson avatar bryce-anderson commented on June 23, 2024

I'm thinking the topic/RequestLineBuilder branch is close enough to what we want to merge it and start to see how the different things such as UriTemplate play with it.

from rho.

arouel avatar arouel commented on June 23, 2024

Looks good. I would merge it.

from rho.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.