Comments (14)
Let me check this
from swifter.
i fixed the code to work with the current swift compiler version. i am quite new to github. if you tell me how, i can submit my changes.
from swifter.
nicecoding, I am not the best at submitting changes either but this may help...
https://github.com/blog/1862-introducing-a-simpler-faster-github-for-mac
from swifter.
Thanks for your answer!
well i know how to commit changes and push them to a remote github repo via command line. i am just wondering if I will need some kind of access or can I just push into this repo without extra permission?
from swifter.
@nicecoding here you have tutorial how to create a pull request.
https://help.github.com/articles/using-pull-requests/
when you are done, I can merge it :)
The problem here is Swift stopped to support multiple subscripts :/ I need to double check but it looks like it's not possible to define following subscripts:
subscript (path: String) -> Handler?
subscript (path: String) -> String?
from swifter.
I already forked your repo and pushed my commits. You need to pull, right?
I simply refactored the class HttpServer and introduced a new Class "HttpServerHandler"
I also changed other compile errors where static initializers where replaced with new constructors /initializers
so now you have to write (which I find even more "readable"):
server.handler["/myFilterPath"] = { response .... }
from swifter.
@nicecoding you can just push it. I will be notified by GitHub :)
from swifter.
into my fork or your repo?
-> my fork is already up to date. i pushed minutes ago
from swifter.
so i guess i now made a pull request to you. hope that works :-)
from swifter.
I am trying to get the server serve file content etc. as raw bytes to e.g. serve images etc. as soon as I am done I ll send you another pull request
from swifter.
@nicecoding I think I was doing the same :) could you please update the push request ?
from swifter.
@glock45 I already made a pull request. I dont know what you mean with "push request". That's my first time doing stuff like that on github. Please tell me what to do
from swifter.
@nicecoding I see it but in the same time you were doing changes I did my own changes :) you need to merge your repo with my recent changes from this repo and create another pull request.
from swifter.
alright, I saw you just commented out the subscript with type String? I refactored The handler... I dunno which solution is better. I didnt change anything else but some language changes that lead to an compile error. If I should still merge, tell me
from swifter.
Related Issues (20)
- websocket sometimes not working in macOS sandbox app HOT 1
- LICENSE file contains placeholder text.
- usleep degrades when using Swifter
- Unable to connect to server HOT 1
- tvOS 16 Beta 2 Unable to override the Stub that has same url
- Builds fails when trying to use `Swifter` in XCUITest HOT 3
- 404 Not Found HOT 1
- Building release is extremely slow
- Enhancement request: Swifter to label .wasm files as "application/wasm" when it serves them
- Can the development on this package be sponsored?
- IOS 16.4problem: Restricted network ports are not allowed HOT 3
- How to get post parameters ?
- How to set multiple responses for one endpoint?
- Question for loading index.html + subdirrectories HOT 1
- Support regular expression
- Bind operation not permitted - MacOS - UITests
- Privacy Manifest HOT 6
- HttpServer does not support for multicast
- Release new version from stable branch (Cocoapods)
- How to use the ssl
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swifter.