Comments (8)
Agreed. Why don't you give it a try and report back? Funny enough, I'm moving to Governator and everything is working really well. Finally in Stage.PRODUCTION
! but don't have the issue you describe. FYI, I usually add an expensive initialization as part of my healthcheck because I like to warm up the JVM before adding it to my load balancers.
from dropwizard-guice.
So you want it to be an eager singleton that has access to Environment
/Configuration
? As @chbatey noted on #19 this can be achieved by moving injector creation to the run method, but at the expense of not being able to autoconfig bundles which some users might rely on.
One possible workaround is to make the singleton lazy and have a managed that initializes it inside the start method (or a healthcheck as @eliast suggested), so you effectively get an eager singleton
from dropwizard-guice.
I'm trying the lazy healthcheck approach. Your updated documentation for #41 helps; it didn't occur to me that it's safe to hold a reference to the GuiceBundle in the application class to make it visible to the run method (I was experimenting with the container, which the environment can return).
Nevertheless there seems to be a square peg and round hole here; is there any way to smooth the edges?
Could you also provide a documentation example for chbatey's approach? (It sounds like he made a pull request, which may be worth looking at.) Specifically, how do you register the bundle given that you don't have a handle on bootstrap in the run method?
Thanks
from dropwizard-guice.
Agreed on the square peg. But there are all kinds of gotchas and nobody has submitted a PR request that actually solves it yet. ;-) Basically, if we want to support bundle injection then we have to create the injector in initialize, else we could initialize the injector during the run phase and everything would be good.
If we keep it this way, we can do everything, we just need to know the exact steps to follow. Not very ideal but works.
from dropwizard-guice.
I got this working using autoconfig + healthchecks.
Theoretically, what would dropwizard need to support to make this more seamless? I.e. what might a possible pull request for dropwizard 0.8 contain that would allow first class guice support?
from dropwizard-guice.
@flavor8 dropwizard uses Jersey which has HK2 built in as injector. Therefore by default, Guice will be an add-on instead of being first class. I'm experimenting with the HK2 Guice Bridge at the moment to see if Guice can work with dropwizard 0.8
from dropwizard-guice.
Any update on this issue?
from dropwizard-guice.
Since this issue was opened we have introduced dropwizard-guicier which creates the Guice injector during the run phase which solves the problems with eager singletons:
https://github.com/HubSpot/dropwizard-guicier
from dropwizard-guice.
Related Issues (20)
- Can not register jersey client in guice
- Binding annotations on providers don't seem to work HOT 1
- AutoConfig should ignore anonymous class HOT 1
- Dropwizard Not Starting Due to HK2 Failure HOT 4
- dropwizrd-guice not working with Dropwizard-core 1.1.0
- LinkageError ... attempted duplicate class definition for name: "org/glassfish/hk2/api/ServiceLocatorState"
- jersey2-guice is defunct HOT 1
- DropWizard 0.9.1 support? HOT 10
- Are there plans to add DropWizard 1.0.0 support? HOT 5
- No License inside Jar file HOT 4
- Getting a warning at startup: "It appears jersey2-guice-spi is either not present or in conflict with some other Jar" HOT 14
- com.google.inject.OutOfScopeException on inject javax.servlet.http.HttpServletRequest HOT 11
- Binding annotations aren't being consistently honored HOT 3
- Integration Test using mocked beans HOT 1
- @BeanParam + @QueryParam don't work with Dropwizard-guice HOT 6
- when i add a filter to jersey , then Jersey error HOT 5
- Compatiblity with Dropwizard 1.0? HOT 27
- AutoConfig not honouring Guice Singleton annotation on resource classes HOT 1
- How exactly HelloWorldConfiguration and Environment get injected in the example HOT 1
- Deprecated API WARNing in v1.0.0.2 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dropwizard-guice.