Overlapping classes with dropwizard-core about dropwizard-guice

[mrserverless]

I think some of these may be coming from jersey2guice and to align them would require a PR to their project.

[jhaber]

Fixed via 2f42df5

[jhaber]

Released as part of 0.8.1.1

[scho]

I still need:

<exclusions>
  <exclusion>
    <groupId>com.google.code.findbugs</groupId>
    <artifactId>annotations</artifactId>
  </exclusion>
  <exclusion>
    <groupId>javax.inject</groupId>
    <artifactId>javax.inject</artifactId>
  </exclusion>
</exclusions>

Otherwise I get:

[WARNING] javax.inject-2.4.0-b10.jar, javax.inject-1.jar define 6 overlappping classes: 
[WARNING]   - javax.inject.Inject
[WARNING]   - javax.inject.Singleton
[WARNING]   - javax.inject.Scope
[WARNING]   - javax.inject.Named
[WARNING]   - javax.inject.Provider
[WARNING]   - javax.inject.Qualifier
[WARNING] jsr305-3.0.0.jar, annotations-3.0.0.jar define 35 overlappping classes: 
[WARNING]   - javax.annotation.RegEx
[WARNING]   - javax.annotation.concurrent.Immutable
[WARNING]   - javax.annotation.meta.TypeQualifierDefault
[WARNING]   - javax.annotation.meta.TypeQualifier
[WARNING]   - javax.annotation.Syntax
[WARNING]   - javax.annotation.Nonnull
[WARNING]   - javax.annotation.CheckReturnValue
[WARNING]   - javax.annotation.CheckForNull
[WARNING]   - javax.annotation.meta.TypeQualifierNickname
[WARNING]   - javax.annotation.MatchesPattern
[WARNING]   - 25 more...
[WARNING] maven-shade-plugin has detected that some .class files
[WARNING] are present in two or more JARs. When this happens, only
[WARNING] one single version of the class is copied in the uberjar.
[WARNING] Usually this is not harmful and you can skeep these
[WARNING] warnings, otherwise try to manually exclude artifacts
[WARNING] based on mvn dependency:tree -Ddetail=true and the above
[WARNING] output
[WARNING] See http://docs.codehaus.org/display/MAVENUSER/Shade+Plugin

[jhaber]

javax.inject:javax.inject and com.google.code.findbugs:annotationsare the "correct" dependencies to use, something else in your dependency tree must be pulling in org.glassfish.hk2.external:javax.inject and com.google.code.findbugs:jsr305

[scho]

For javax.inject the reason is dropwizard-client:

[INFO] +- io.dropwizard:dropwizard-client:jar:0.8.1:compile
[INFO] |  +- org.glassfish.jersey.core:jersey-client:jar:2.17:compile
[INFO] |  |  +- org.glassfish.jersey.core:jersey-common:jar:2.17:compile
[INFO] |  |  |  +- org.glassfish.jersey.bundles.repackaged:jersey-guava:jar:2.17:compile
[INFO] |  |  |  \- org.glassfish.hk2:osgi-resource-locator:jar:1.0.1:compile
[INFO] |  |  +- org.glassfish.hk2.external:javax.inject:jar:2.4.0-b10:compile
[INFO] |  |  \- org.glassfish.hk2:hk2-locator:jar:2.4.0-b10:compile
[INFO] |  +- io.dropwizard.metrics:metrics-httpclient:jar:3.1.1:compile
[INFO] |  \- org.glassfish.jersey.connectors:jersey-apache-connector:jar:2.17:compile

Isn't it a common usecase to use dropwizard-client together with dropwizard-guice?

[scho]

For com.google.code.findbugs:jsr305 the reason is dropwizard-core:

[INFO] +- io.dropwizard:dropwizard-core:jar:0.8.1:compile
[INFO] |  +- io.dropwizard:dropwizard-util:jar:0.8.1:compile
[INFO] |  |  +- com.google.code.findbugs:jsr305:jar:3.0.0:compile

I am far from being a maven expert. But in my opinion this should be fixed somehow in dropwizard-guice.

[jhaber]

Yeah, unfortunately getting rid of those warnings will require an exclusion on jsr305