Remove Class RegExp is unreliable about youmightnotneedjquery

[zackbloom]

Good point, how about:

el.className = el.className.replace(new RegExp('(^|\\b)' + className.split(' ').join('|') + '(\\b|$)', 'gi'), ' ')

[darrell-newman]

Using \b won't handle hyphens in class names correctly.

You still need to add parentheses around that middle | section or it'll fail for my first test case.

[zackbloom]

I can't actually reproduce the first issue (the need for parens), but the hyphenated class issue is a problem.

[darrell-newman]

Here's a complete test case for the first issue:

function removeCls(el, className) {
    if (el.classList) {
        el.classList.remove(className);
    }
    else {
        el.className = el.className.replace(new RegExp('(^|\\b)' + className.split(' ').join('|') + '(\\b|$)', 'gi'), ' ');
    }
}

var span = document.createElement('span');

span.className = 'a b cab';

removeCls(span, 'a b');

alert(span.className);

It's a bit more subtle than that though. Is the removeCls function supposed to support space-separated classes as an argument or not? The RegExp version seems to suggest yes (it splits and joins them) but it then gives the wrong result. The classList implementation just throws an error.

[zackbloom]

The conclusion we came to when dealing with the same issue on add class, was that we need two comparisons, one called 'add class', the other called 'add classes'. The jQuery would be the same for both, but the js will differ.