GithubHelp home page GithubHelp logo

重构 Upload 组件 about element3 HOT 16 CLOSED

hug-sun avatar hug-sun commented on May 18, 2024
重构 Upload 组件

from element3.

Comments (16)

weihaiyu avatar weihaiyu commented on May 18, 2024

我即将重构这个组件。doing

from element3.

shengxinjing avatar shengxinjing commented on May 18, 2024

重新开放占位

from element3.

trueLoving avatar trueLoving commented on May 18, 2024

这个组件我承包了。doing

from element3.

liushuiyuan001 avatar liushuiyuan001 commented on May 18, 2024

@trueLoving 请问你还开发吗?要不开发了我就接手了

from element3.

liushuiyuan001 avatar liushuiyuan001 commented on May 18, 2024

@shengxinjing 没人响应这个组件我就承包了

from element3.

liushuiyuan001 avatar liushuiyuan001 commented on May 18, 2024

重构完成,剩余test待补充

from element3.

shengxinjing avatar shengxinjing commented on May 18, 2024

@liushuiyuan001 可以先把逻辑代码提交 我给你merge

from element3.

zhangpaopao0609 avatar zhangpaopao0609 commented on May 18, 2024

好不容易重构还写了测试,结果被关了,👀o(╥﹏╥)oo(╥﹏╥)oo(╥﹏╥)o

from element3.

zhangpaopao0609 avatar zhangpaopao0609 commented on May 18, 2024

看了现在的upload组件,觉得有可优化的点,还有没有写测试,我可以不可以拉下来优化并且把测试加上呀

from element3.

liushuiyuan001 avatar liushuiyuan001 commented on May 18, 2024

好不容易重构还写了测试,结果被关了,👀o(╥﹏╥)oo(╥﹏╥)oo(╥﹏╥)o

兄弟,你看我comment时间,组件是我认领,代码其实早写好了,比你早了快一周了.

from element3.

liushuiyuan001 avatar liushuiyuan001 commented on May 18, 2024

看了现在的upload组件,觉得有可优化的点,还有没有写测试,我可以不可以拉下来优化并且把测试加上呀

Test这两天就会提交pr.至于优化等等你可以提交pr.
@Arrow-zb

from element3.

shengxinjing avatar shengxinjing commented on May 18, 2024

@Arrow-zb 难道有误伤,前几天清理了一波,最近还有很多可以提,比如bug,测试,文档 都可以的 优先给你merge

from element3.

caikan avatar caikan commented on May 18, 2024

@liushuiyuan001 已经在做了的话,可以把PR先发出来,完成之前可以在PR标题加上 WIP: 前缀,完成后再去掉,也能方便大家随时review

from element3.

liushuiyuan001 avatar liushuiyuan001 commented on May 18, 2024

@liushuiyuan001 已经在做了的话,可以把PR先发出来,完成之前可以在PR标题加上 WIP: 前缀,完成后再去掉,也能方便大家随时review

@caikan 下午应该会把test pr提交上

from element3.

runner-up-js avatar runner-up-js commented on May 18, 2024

这个组件这么吃香呀,哈哈哈哈

from element3.

cuixiaorui avatar cuixiaorui commented on May 18, 2024

已经完成重构

from element3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.