GithubHelp home page GithubHelp logo

Comments (4)

sanchit-gandhi avatar sanchit-gandhi commented on August 24, 2024 1

For sure! Thanks for reporting it! I'll have a look to see if there's a way we can avoid this in the future (potentially being more explicit in the text?)

from community-events.

sanchit-gandhi avatar sanchit-gandhi commented on August 24, 2024

Hey @BirgerMoell, sorry to hear that you lost some files 😥

This behaviour looks to be a combination of a couple of things:

  1. The output_dir is set to ./ (i.e. the directory in which the script run.sh is saved). The README instructions suggest that you run the script from within a new model repository cloned from the Hugging Face Hub (i.e. set your current working dir to a cloned model repo). This means that the only files that can be touched by the script are those within the model repository, and any files outside the repo are safe! The Trainer is sandbox in this regard, it only has access to the files you specify in the output_dir. If you don't want Trainer to touch files in your current working dir, you need to run the script from a different dir or set output_dir accordingly.
  2. This is the desired behaviour by setting overwrite_output_dir (see docs). I'm afraid we can't change this as it's required for over-riding checkpoints and flushing dirs.

So what you can do is run the script from within a new model repo or set --overwrite_output_dir=False \ in the arguments to run.sh. We're trying to give instructions that can be used by as many participants as possible. They've been stress tested when all of the instructions are run sequentially, but the behaviour will no doubt be different when different steps are run. Sorry to hear that you lost files. If this was a model repo cloned from the HF Hub could you revert to the last commit?

from community-events.

BirgerMoell avatar BirgerMoell commented on August 24, 2024

I got most of the stuff back through git but I seemed a bit unexpected so I just wanted to report it to make sure it behaved as it was intendent.

from community-events.

sanchit-gandhi avatar sanchit-gandhi commented on August 24, 2024

(It will only do a full wipe if the output dir is not a HF repo:
https://github.com/huggingface/transformers/blob/6a707cf586f37865d1a9fac02c56c43cf8dcf979/src/transformers/trainer.py#L3326)

from community-events.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.