GithubHelp home page GithubHelp logo

No need for `perform_types` about sidekiq.cr HOT 3 CLOSED

asterite avatar asterite commented on August 15, 2024 1
No need for `perform_types`

from sidekiq.cr.

Comments (3)

asterite avatar asterite commented on August 15, 2024

The code is kind of hard to read because that macro is inside another macro... the \{% things basically say "don't execute this now, instead generate this", so later when the method_added macro is added to the final class it can be executed well.

from sidekiq.cr.

asterite avatar asterite commented on August 15, 2024

One last thing: the name comparison should probably be if a_def.name == "perform", but right now that doesn't work, I need to define comparison between string literals and macro ids.

from sidekiq.cr.

mperham avatar mperham commented on August 15, 2024

Whoa, that's some metametaprogramming BUT it solves a major API compatibility issue with Sidekiq.rb: having to define arg types separately from perform. THANK YOU!

from sidekiq.cr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.