1.5.0: One test fails about curtail

[Huluti]

@bertob should I remove padding from screenshots?

[bertob]

Not sure what you mean by padding in the context of screenshots

[Huluti]

Seems to be the errors reported here:

• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen1.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen1.png]
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen2.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen2.png]
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen3.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen3.png]

[bertob]

Huh, not sure what that means. Does it still happen if you just retake the screenshot?

[gavr123456789]

Same error on Arch GNOME 43 when building from AUR https://aur.archlinux.org/packages/curtail-git

[19/19] Generating data/com.github.hul...tail.appdata.xml with a custom command
==> Starting check()...
ninja: no work to do.
ninja: Entering directory `/home/gavr/.cache/yay/curtail-git/src/build'
ninja: no work to do.
1/3 Validate desktop file          OK              0.01s
2/3 Validate schema file           OK              0.00s
3/3 Validate appstream file        FAIL            0.26s   exit status 1
>>> MALLOC_PERTURB_=194 /usr/bin/appstream-util validate data/com.github.huluti.Curtail.appdata.xml
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
stdout:
data/com.github.huluti.Curtail.appdata.xml: FAILED:
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen1.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen1.png]
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen2.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen2.png]
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen3.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/Huluti/Curtail/master/data/screenshots/screen3.png]
stderr:
Validation of files failed
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――


Summary of Failures:

3/3 Validate appstream file FAIL            0.26s   exit status 1

Ok:                 2   
Expected Fail:      0   
Fail:               1   
Unexpected Pass:    0   
Skipped:            0   
Timeout:            0   

Full log written to /home/gavr/.cache/yay/curtail-git/src/build/meson-logs/testlog.txt
==> ERROR: A failure occurred in check().
    Aborting...
 -> error making: curtail-git

[Huluti]

Seems to be related to this:
https://gitlab.gnome.org/GNOME/gnome-screenshot/-/issues/162
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3143
https://gitlab.gnome.org/GNOME/gtk/-/issues/5093

[Huluti]

Should be fixed in ab0e268.

$ appstream-util validate data/com.github.huluti.Curtail.appdata.xml.in 
data/com.github.huluti.Curtail.appdata.xml.in: OK