GithubHelp home page GithubHelp logo

Comments (4)

wahidshalaly avatar wahidshalaly commented on August 17, 2024

I think it can be better if we defined precision as percentage. Let's say by default precision = 0.75 if someone prefers to override it to be either 0.5 or 0.95 for example, that's fine.

0.75 of a minute => if (delta >= 45 seconds) => about a minute
0.75 of a day => if (delta >= 18 hours) => about a day
0.75 of month (30 days) => if (delta >= 22.5 days) => about a month
0.75 of year (365 days) => if (delta >= 273.75 days) => about a year

There's another place we can examine for ideas.. Ruby::ActionView::Helpers::DateHelper distance_of_time_in_words

from humanizer.

MehdiK avatar MehdiK commented on August 17, 2024

That's a great idea @waheedsayed. Thanks.

By breaking change I didn't mean API breaking change but behavioural. After this change the call that would previously return "a few hours ago" will return "yesterday" and that's a breaking change from my point of view.

I think we could implement this and set the default to 1 for now, and as part of V2 we could decrease it a bit.

from humanizer.

MehdiK avatar MehdiK commented on August 17, 2024

After reading through #114 by @waheedsayed, it turns out the current implementation is precision based but the (.75) precision is precalculated and hardcoded on each time unit! So we can replace the existing algorithm with the one created in #114.

from humanizer.

MehdiK avatar MehdiK commented on August 17, 2024

Done in #165

from humanizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.