Comments (4)
I think it can be better if we defined precision as percentage. Let's say by default precision = 0.75 if someone prefers to override it to be either 0.5 or 0.95 for example, that's fine.
0.75 of a minute => if (delta >= 45 seconds) => about a minute
0.75 of a day => if (delta >= 18 hours) => about a day
0.75 of month (30 days) => if (delta >= 22.5 days) => about a month
0.75 of year (365 days) => if (delta >= 273.75 days) => about a year
There's another place we can examine for ideas.. Ruby::ActionView::Helpers::DateHelper distance_of_time_in_words
from humanizer.
That's a great idea @waheedsayed. Thanks.
By breaking change I didn't mean API breaking change but behavioural. After this change the call that would previously return "a few hours ago" will return "yesterday" and that's a breaking change from my point of view.
I think we could implement this and set the default to 1 for now, and as part of V2 we could decrease it a bit.
from humanizer.
After reading through #114 by @waheedsayed, it turns out the current implementation is precision based but the (.75) precision is precalculated and hardcoded on each time unit! So we can replace the existing algorithm with the one created in #114.
from humanizer.
Done in #165
from humanizer.
Related Issues (20)
- toMetric() enhancements
- TimeSpan Humanize ignored toWords: false parameter HOT 2
- Code Quality: Enable .NET PublishTrimmed
- Incorrect usage of paucal grammatical number for pl for time units
- FR: alternative EnumCache and extensions to De/Humanize enums
- How to show smaller than milliseconds for TimeSpan? HOT 1
- Pluralize/Singularize - Process HOT 2
- Convert month number to text. Ex: 1 = "January" HOT 3
- Pluralization of Taxes. HOT 2
- Latest Beta 13 is still not compatible with .net 8 HOT 2
- Can we solve the problem of AIGC detection?
- TimeSpanHumanize_MultipleMilliseconds issue
- RomanNumeralExtensions.FromRoman incorrectly handles Latin Small Letter Dotless I
- The Enum Humanizer Conversion to its Description not working on .Net 7 Project HOT 7
- Mixed languages in TimeToClockNotation (ITimeOnlyToClockNotationConverter implementations do not forward the culture to ToWord)
- Convert Equality Comparison Words To Symbols
- Incorrect language with only core HOT 3
- Enums not picking up resource text on release mode
- Adding welsh (cy) support HOT 2
- Drop netstandard 1.0 support HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from humanizer.