Comments (6)
Definitely seems to be an issue with the headers, setting the $message_args['headers']['Content-Type']
default to apply_filters( 'wp_mail_content_type', 'text/html' )
fixes the issue.
I'm sure it probably breaks other things though. I'm not sure why that filter isn't being set correctly by gforms.
from aws-ses-wp-mail.
My guess would be differing defaults. Can you trace down the wp_mail
call and find what's passed into it?
from aws-ses-wp-mail.
Looks like it's a case sensitivity thing. It passes in Content-type
rather than Content-Type
in the headers.
from aws-ses-wp-mail.
That was my second guess :) Headers are case-insensitive, so we should take this into account when we're merging this. Potentially, we can use Requests_Utility_CaseInsensitiveDictionary
which is designed for exactly this purpose, but likely overkill here.
from aws-ses-wp-mail.
After a bit more digging, it looks like the real issue is that in this case the headers are being unset here.
You end up with an empty array before the camel case conversion runs and the defaults are merged.
I'm having a little trouble wrapping my head around exactly why all the values are being unset though...
from aws-ses-wp-mail.
Aha, discovered what's happening here.
Gravity Forms sets $headers['Content-type'] = "Content-type: text/html ..."
, which is redundant. The unset is there so that the old header is deleted when we convert, but that breaks this use case.
Easy enough to fix.
from aws-ses-wp-mail.
Related Issues (20)
- Fails to use key & secret on local dev environment HOT 5
- Correct typo in for WP-CLI in the readme
- AWS_SES_WP_MAIL_USE_INSTANCE_PROFILE is not actually used HOT 3
- Undefined index: domain
- trigger_error has too many parameters HOT 1
- Gravity Forms HTML email notifications formatting issues and incorrect from email HOT 1
- trigger_error not called correctly?
- Add support for attachments HOT 3
- Allow external AWS SDK HOT 1
- Update AWS sdk as its out of date. HOT 9
- Class 'Aws\Ses\SesClient' not found HOT 4
- Submitted for verification. Make sure you have the following DNS records added to the domain:
- Encode Unicode site names before sending HOT 1
- Clean email subject content.
- SMTP_FROM and SMTP_NAME HOT 1
- The `pre_wp_mail` filter is not respected
- Docs: explain how the WP-CLI integration works HOT 9
- Support Reply-To header HOT 2
- Make note for Moving Out of the Amazon SES Sandbox HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-ses-wp-mail.