GithubHelp home page GithubHelp logo

Comments (8)

luke- avatar luke- commented on June 10, 2024

Maybe we should throw a Yii::warning in such cases?

from linkpreview-issues.

yurabakhtin avatar yurabakhtin commented on June 10, 2024

@luke- I cannot understand how this module should work.
When I create a new post with text like Test http://spotify.com text I don't see the link is rendered with thumbnail icon as it is displayed on doc page. Should I enable something else to make this module works?

I run composer install successfully.
But I can run npm install without errors only if remove a comma after "doc": "docs", and if remove completely the line "euskadi31/Opengraph": "^1.0.0"`` because it seems the package doesn't exists, I got the error:

npm ERR! code EINVALIDPACKAGENAME
npm ERR! Invalid package name "euskadi31/Opengraph": name can only contain URL-friendly characters

This is a single package so if we will remove I don't see a reason to keep the package.json at all. Please correct me if I am wrong here.

from linkpreview-issues.

luke- avatar luke- commented on June 10, 2024

@yurabakhtin I fixed the problem with the Composer Json, seems that ComposerV2 had a problem with the capitalization of the package name.

Can you try a composer install again?

from linkpreview-issues.

yurabakhtin avatar yurabakhtin commented on June 10, 2024

@luke- Yes, in my previous comment I forgot to report about the issue in composer.json, I fixed that too on my local file without commit yet, but if you did this first then thanks, , so I could install it after the same fix
However as I wrote above the problems exist in the package.json and it seems we don't need that at all, can you please check that?

from linkpreview-issues.

luke- avatar luke- commented on June 10, 2024

@yurabakhtin Yes, I think we can delete the package.json file. Does the module work for you now?

from linkpreview-issues.

yurabakhtin avatar yurabakhtin commented on June 10, 2024

@luke- Yes, the problem was in redirect URL on the server side of the URL, for example, the url https://www.spotify.com/ redirects me to https://www.spotify.com/ru-ru/ so I need to use this url to test this module.

from linkpreview-issues.

yurabakhtin avatar yurabakhtin commented on June 10, 2024

@luke- I have implemented to display the validation errors after fetching an URL:

fetch_errors

MR https://git.humhub.org/modules/linkpreview/-/merge_requests/1

from linkpreview-issues.

luke- avatar luke- commented on June 10, 2024

@yurabakhtin Thanks & Merged

from linkpreview-issues.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.