Dialog.Root's onOpenChange callback is not called when dialog open about bits-ui

[huntabyte]

Good news, I identified the issue and am working on a patch for it now!

[JYLN]

@huntabyte The issue with select is confirmed fixed within this minimal repro I was working up to open a separate issue on! 🎉

https://stackblitz.com/edit/github-lsakyy

Genuinely appreciate all you do for the Svelte community!

[huntabyte]

This issue would fall back to https://github.com/huntabyte/bits-ui, so will move it there

[JustDenP]

@huntabyte Thank you, also form selector component in shadcn is broken with bits-ui 0.9.2 and can't be opened at all. You can check it in docs with form example. https://www.shadcn-svelte.com/docs/components/select#form

Version 0.9.1 works fine for me.

[huntabyte]

hm I do see that now that you mention in 🤔

[huntabyte]

Also, onOpenChange is intended to be used for internal changes that are out of your control, and actually the logic of updating your bind:open is handled there. So when you change it outside of it, it would end up calling it twice which I expect you wouldn't want.

[huntabyte]

The issue I'm referring to is for the select btw.

As mentioned, the onOpenChange couldn't work the way you expect it to due to how it synchronizes the bind state with the internal state. onOpenChange is designed to be used when you aren't controlling the state from outside the component with bind:open.

Otherwise, it results in behavior like this, where the change function is fired multiple times, once when it changes, and a second time when it syncs the value.

CleanShot.2023-11-09.at.20.20.29.mp4

I could possibly explore some alternative approaches to this, but is very low on my priority list at the moment.

The idea is that if you are modifying the state outside the component, you know when it is going to change and should apply whatever logic you expect to happen on change there for the time being.

[huntabyte]

Going to close this issue now as the behavior is working as initially intended, maybe in the future during a refactor (maybe svelte 5) we will be able to accommodate this, but at the moment the juice isn't worth the squeeze!