Prevent Select onValueChange from firing on init about bits-ui

[saturnonearth]

Also, on another note, is there a reason why we need to pass:

type SelectOption<T> = {
	value: T;
    label?: string
}

to the selected prop, as opposed to just a string value?

This seems odd to me because

1. What purpose would the label serve in this situation?
2. It strays away from the native Select where you just pass a straight value.

It's not a huge deal but it does (unless I am missing an easy way), prevent me from binding selected to a single writable store String, since it is now an object.

I'm sure there could be reasons for this so I don't want to sound rude!

[pheuter]

On a possibly related note, <Select.Input name="favoriteFruit" /> doesn't appear to work, the value of the hidden input field is set to "[object Object]". It used to be set to the option.value automatically.

[Rykuno]

On a possibly related note, <Select.Input name="favoriteFruit" /> doesn't appear to work, the value of the hidden input field is set to "[object Object]". It used to be set to the option.value automatically.

Also having this issue atm with Superforms. If anyone has a solution that would be pretty cool in the meantime.

[huntabyte]

^ @saturnonearth that is correct. We had issues with SSR & attempting to keep the select label/value combo in sync, especially when you're conditionally rendering the options under an {#if open} (which we're doing in bits to support transitions).

I'm working on trying to fix the issues you all are experiencing though!

[mcmxcdev]

+1 Ohh this is bothering me too, great that you confirmed this!

I am using raw melt-ui though, that would need to be fixed there I assume.

[huntabyte]

@mcmxcdev , I believe I know why this is happening, if you wouldn't mind opening an issue on Melt explaining some situations that you've run into this, it would be incredible!

[huntabyte]

I believe I may have fixed this, can you confirm using the latest version of bits-ui?

[saturnonearth]

I believe I may have fixed this, can you confirm using the latest version of bits-ui?

It seems to work but...it's not liking the new prop: selected.

Type 'string' is not assignable to type 'SelectOption<unknown>'

I am just passing a Store with a string in it.

Also, should it be onSelectChange instead of onSelectedChange to match melt-ui?

[huntabyte]

Yeah it should be onSelectedChange I will make that fix! So SelectOption looks like this:

type SelectOption<T> = {
	value: T;
    label?: string
}

So you'd need to set the value to that string!

[saturnonearth]

I was wondering, is the default value that displays in the Select always supposed to be the placeholder, even if the selected value matches one of the Options? This seems to go against the native Select behavior, but I wasn't sure if this was intentional or not.

As an example...

If the user has the value "apple" value already selected when loading the page, one would assume the Select shows this:

But it's actually showing...

[mcmxcdev]

I think that was also an issue I had with Select, the label was not synced up with the value.

[saturnonearth]

In regards to....

I was wondering, is the default value that displays in the Select always supposed to be the placeholder, even if the selected value matches one of the Options? This seems to go against the native Select behavior, but I wasn't sure if this was intentional or not.

and....

I think that was also an issue I had with Select, the label was not synced up with the value.

I found the reason for this behavior. Basically whatever the selected label is:

type SelectOption<T> = {
	value: T;
    label?: string
}

will show up as the default label (even if the value is set to the correct associated item.

If there is no label property present for selected, it will default to the Select.Trigger Select.Value placeholder value.

[0xHati]

Yeah it should be onSelectedChange I will make that fix! So SelectOption looks like this:

type SelectOption<T> = {
	value: T;
    label?: string
}

So you'd need to set the value to that string!

I don't get typing for the SelectOption in my onSelectedChange function.

(property) selected?: SelectOption<unknown> | undefined

I'm doing something like this to make a select component that I can reuse in my app, built on the blocks that shadcn gives me. Which in turn uses bits ui.

<script lang="ts">
	import * as Select from '$components/ui/select';
	import type { SelectOption } from '@melt-ui/svelte';
	import type { OnChangeFn } from 'bits-ui/dist/internal';

	export let data: Record<string, string>[];
	export let inputName: string;
	export let onSelectedChange: OnChangeFn<SelectOption<any> | undefined> | undefined;

	export let defaultSelected: SelectOption<string>;
</script>

<Select.Root
	selected={{ value: defaultSelected.value, label: defaultSelected.label }}
	{onSelectedChange}
>
	<Select.Trigger class="w-[180px]">
		<Select.Value />
	</Select.Trigger>
	<Select.Content>
		{#each data as { value, label }}
			<Select.Item {value} {label}>{label}</Select.Item>
		{/each}
	</Select.Content>
	<Select.Input name={inputName} />
</Select.Root>

The select primitive from shadcn

<script lang="ts">
	import { Select as SelectPrimitive } from 'bits-ui';

	type $$Props = SelectPrimitive.Props;

	export let selected: $$Props['selected'] = undefined;
	export let open: $$Props['open'] = undefined;
</script>

<SelectPrimitive.Root bind:selected bind:open {...$$restProps}>
	<slot />
</SelectPrimitive.Root>

Atm it's set to any, but I'd like it to set to the type of the selected. If I understand correctly that should be the case. I'm using bits and shadcn.

export let onSelectedChange: OnChangeFn<SelectOption<any> | undefined> | undefined;

[huntabyte]

Closed by #184