GithubHelp home page GithubHelp logo

Comments (7)

Hutchy68 avatar Hutchy68 commented on August 22, 2024

Thanks for reporting, I’ll investigate. It definitely should not be doing that.

from pivot.

Hutchy68 avatar Hutchy68 commented on August 22, 2024

Could you try changing this in your pivot features array? Set 'IeEdgeCode' => 1, to 'IeEdgeCode' => 0, Although I suspect MW 1.30 is just adding the meta tag without testing if IE = 9 or since the skin tests for IE=9 there is a conflict with the shim they added. That meta tag should NOT be inserted into head of a browser that is not IE 9 and it is there for Chrome and Firefox. 😞

from pivot.

Hutchy68 avatar Hutchy68 commented on August 22, 2024

Sorry for the delay, just had a chance to really look at this. Probably about time to have a real discussion on supporting IE 8. IE 8 support ended a while ago. Technically, IE 9 and 10 has ended too. Anyway, here is the fix.

Line 4 of /assets/scripts/pivot.js
Change

if (!jQuery.support.cssFloat) { jQuery('html').addClass('lt-ie9').addClass('no-js'); }

to

// if (!jQuery.support.cssFloat) { jQuery('html').addClass('lt-ie9').addClass('no-js'); }

I'm going to look at this further and probably just remove support for IE 8 completely. Or move it off to only load the CSS if IE 8 is detected properly. We have modernizr loaded too which would be a better way to detect.

from pivot.

philippenoel73 avatar philippenoel73 commented on August 22, 2024

Thank you very much. Putting in comment line 4 of /assets/scripts/pivot.js make it work perfectly now.

Best Regards,
Phil

from pivot.

BuildAndDie avatar BuildAndDie commented on August 22, 2024

I was having this exact same problem, the real issue I had was that when viewing on mobile, it wasn't make the navigation sidebar go away. This fixed it all!

from pivot.

kghbln avatar kghbln commented on August 22, 2024

Since MW is no longer supporting IE 8 either this fix should imho go into 2.0 / Edit: Oops, I thought this was about Foreground. Still, pivot could ship with the fix as a 1.1.0?

from pivot.

Hutchy68 avatar Hutchy68 commented on August 22, 2024

Closing, fixed in v2.0 found in develop branch

from pivot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.