Comments (5)
develop branch is now completely broken with commit #52
I don't know why there's a problem I use this branch atm without a problem.
skin.json calls "assets/stylesheets/font-awesome.min.css", missing min.css file in assets. Should just be font-awesome.css.
I forgot to upload font-awesome.min.css
You have...
$out->addHeadItem('font', '');
You are calling an href with a hard set link. What about those who use w/ or whatever/ directory to install MediaWiki.
the path is relative to the directory. It can't cause any problems
https://github.com/Tealk/pivot/tree/font-awesome_css
this version is currently running error-free for me
from pivot.
I don't know why there's a problem I use this branch atm without a problem.
skin.json calls "assets/stylesheets/font-awesome.min.css", missing min.css file in assets. Should just be font-awesome.css.
skin.json
missing resource, breaks everything, so yes the file you forgot to upload is necessary to keep things from breaking. It looks like your version is just a minified version of font-awesome.css. I just pushed back a few things to fix. You can PR the ...min.css
back and remove the old font-awesome.css
file, but will have to tweak the skin.json
file again. Missing the left-canvas
in fontawesome.css
too.
the path is relative to the directory. It can't cause any problems
It can and it did. href="/skins...
would look for domainname.com/skins/....
href="/w/skins...
looks in the domainname.com/w/skins/...
Yes, your call is relative, but relative to the domain. Not the true path of the domain if MW is installed in a directory not the root.
href="'.$wgLocalStylePath.'/pivot
$wgLocalStylePath will automatically set the first of the relative path /w/skins
or /skins
or /wiki/skins
or even /wiki/w/skins
if someone placed a MediaWiki instance in a directory called wiki
and still added a w
directory in that. Could also use $wgStylePath which is the same as $wgLocalStylePath, "{$wgScriptPath}/skins"
See, https://www.mediawiki.org/wiki/Manual:$wgLocalStylePath
My only goal was to get develop
working quickly if anyone wants to use or test it.
from pivot.
Missing the left-canvas in fontawesome.css too.
which left-canvas
?
have add {$wgScriptPath}
to Pivot.skin.php
from pivot.
Pull down the branch changes. Some I already made.
from pivot.
This branch is now fixed and I am going to release it after I finish here and as soon as I update the CHANGELOG.md
file and set a version. I made some changes and pushed a new README.md
.
Changes in README.md
was updating all the Features List and settings, adding and removing some. Need to document this on the live site too. Next couple of big changes on the PR #52 were updating all of Foundation's js to v5.5.3 and pulling in all their changes to their branch of Foundation 5. There were some improvements to address warnings of deprecation of in code. My developer console thanked me 😉 I called the version v5.5.3master
just to denote the change.
Also, I added preload of Font Awesome as a feature. Another warning in develop console, preloading the font but not using it early. I also took these other things into consideration when adding it as a feature:
- MIME type server errors, fix your server if you can
- Fonts should load what the browser wants and specific browsers load the font based on what is best for them.
- woff2 is a standard most modern browsers are moving towards if they aren't there already. However, the browser should be able to load the font which it chooses to load, woff2, woff, ttf, etc.... see first point, fix MIME type output on your server.
from pivot.
Related Issues (20)
- Icons in navbar doesn't show in certain browsers HOT 40
- Sidebar text color ignored when highlighted in mobile HOT 1
- Mobile / small screen left menu is purple, not blue HOT 1
- Icons not supported in MW 1.35 HOT 2
- renderSidebar causing InvalidArgumentException HOT 1
- Off-canvas-menu only closing when clicked on icon HOT 1
- Vertical align of grids content HOT 3
- Font awesome for cyrillic HOT 1
- "Search for pages containing" not displayed
- Font size in Pivot 2.2.2/2.3.0 is larger than in 2.2.0
- User menu and actions menu not working
- Hardcoded /w/ folder in pivot.css leads to resource failure
- Incompatible with MW 1.38 - White screen HOT 8
- In what css is the background color for the pages? HOT 5
- Not Compatible with MW 1.34.1 - Error 500 (fresh install, no extensions) HOT 3
- Off canvas menu animates during page transition sometimes
- Mobile layout - Recent changes checkboxes HOT 2
- Title header color and text centering HOT 5
- [Enhancement] Left-menu search (on mobile widths only) doesn't auto-complete HOT 3
- Login and personal_urls HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pivot.