Comments (25)
Ok, try checking out master and pulling the changes. This commit should have fixed it 56a6ed0 and I updated the release to point at the correct tag.
from pivot.
Actually, both are broken on mobile...left and right.
Can you make sure all files caches are cleared, js really important.
from pivot.
Yep, all js is broken even actions menu. I am running 2.0.0 without the issues and cleared all cached files. Other site was not caching anything and no issues either.
from pivot.
No, clearing the cache does not help at all. I switched to CACHE_NONE cleared the browser cache, disabled all related configuration settings but still I am seeing this issue.
from pivot.
CDN? Not all the event listeners are loading. I don't see any errors in the console, but I did change the namespace of Foundation.js to match what it is now, 5.5.3master.
from pivot.
I do not know what to do about this.
from pivot.
Do you have a CDN in front of the server to deliver content. Cloudflare or something?
from pivot.
Do you have a CDN in front of the server to deliver content. Cloudflare or something?
No.
from pivot.
I'm looking at debug=true for a comparison. It doesn't appear the js is loading at all from Foundation but there is no 404, missing or console errors being logged. Let me try this on 1.27 too. I'm testing 1.30
from pivot.
Are you on master or develop? Did you pull down changes?
from pivot.
Are you on master or develop? Did you pull down changes?
I checked out v2.0.0 so I should be on master. I just checked out version 2.0.0 on sandbox which is running MW 1.30.0 and moreover on the same server. It is working over there so most probably the new version is not compatible with MW 1.27.x
from pivot.
Yep, checkout branch v1.x.x ( at least I had a fallback 😉 ) and revert the site back to v1. I need to look at why 1.27 is not allowing the js to load.
from pivot.
....and I just updated the release to show need 1.30 until I figure out what the heck is going on.
from pivot.
Will do. Yeah, having the 1.x branch was a very good idea.
from pivot.
....and I just updated the release to show need 1.30 until I figure out what the heck is going on.
I will also be curious to see which version is breaking. Perhaps it works for 1.28 or 1.29 though 1.28 is obsolete anyways.
from pivot.
Ok, try checking out master and pulling the changes. This commit should have fixed it 56a6ed0 and I updated the release to point at the correct tag.
Done. Cool, Pivot is back in business for MW 1.27! You can now do the 2.0.1 release. I believe changing the tag of 2.0.0 is not semver.
from pivot.
You can now do the 2.0.1 release. I believe changing the tag of 2.0.0 is not semver.
Ah, already done the 2.0.0 way. I guess in future ... Anyways thanks a lot for tackling this issue!
from pivot.
I am a bit confused now. When checking out v2.0.0 I should be getting 15cce18 as tagged but I am getting b4c88e7?
from pivot.
Normally would have but.... ugh I should have released a beta first. Pretty excited to get it out and never imagined it would Bork 1.27. A bit easier to just update the tag since it was only a few hours.
from pivot.
Normally would have but.... ugh I should have released a beta first.
No worries. It is sorted out now. :)
from pivot.
For some reason it isn't hyperlinking like other extensions. One of mine...
Foreground either
I have noticed on GitHub repos, no hyperlinks and they are not updating. They do link and update to Phabricator commits.
from pivot.
I think that extensions and skins must be in the WMF-repo to work with links.
from pivot.
I agree but that means it must be hard coded in.
from pivot.
I agree but that means it must be hard coded in.
Not necessarily. When reporting an issue here GitHub detects the revision and links to it as seen in my report here: #59 (comment)
from pivot.
No I mean hardcoded in MediaWiki for specialpage.php and the output of Special:Version
from pivot.
Related Issues (20)
- Icons in navbar doesn't show in certain browsers HOT 40
- Sidebar text color ignored when highlighted in mobile HOT 1
- Mobile / small screen left menu is purple, not blue HOT 1
- Icons not supported in MW 1.35 HOT 2
- renderSidebar causing InvalidArgumentException HOT 1
- Off-canvas-menu only closing when clicked on icon HOT 1
- Vertical align of grids content HOT 3
- Font awesome for cyrillic HOT 1
- "Search for pages containing" not displayed
- Font size in Pivot 2.2.2/2.3.0 is larger than in 2.2.0
- User menu and actions menu not working
- Hardcoded /w/ folder in pivot.css leads to resource failure
- Incompatible with MW 1.38 - White screen HOT 8
- In what css is the background color for the pages? HOT 5
- Not Compatible with MW 1.34.1 - Error 500 (fresh install, no extensions) HOT 3
- Off canvas menu animates during page transition sometimes
- Mobile layout - Recent changes checkboxes HOT 2
- Title header color and text centering HOT 5
- [Enhancement] Left-menu search (on mobile widths only) doesn't auto-complete HOT 3
- Login and personal_urls HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pivot.