GithubHelp home page GithubHelp logo

Comments (5)

HydrelioxGitHub avatar HydrelioxGitHub commented on July 22, 2024

Good idea, I 'm a little busy for the next week. But I will try to implement this when I will have some free time.

from pyyeelight.

skorokithakis avatar skorokithakis commented on July 22, 2024

I might issue a few pull request, I need this for the cli I'm writing. Will you at least be available to merge them and push to pypi?

from pyyeelight.

HydrelioxGitHub avatar HydrelioxGitHub commented on July 22, 2024

As I write on Twitter, the future development of this library will be done to handle rgb bulb and White bulb as well.
I think there will be a generic bulb class and some rgb class and white class with specific method and heritage from the generic class.

I will welcome your PR when this structure will be ok. I also need to write some unit tests if the library become collaborative to be sure that modification will not break something. I hope to achieve this early in december.

Sorry for being so long !

from pyyeelight.

skorokithakis avatar skorokithakis commented on July 22, 2024

Hmm, will this structure change affect anything in my PR? I'm getting my utility ready now, so I would like this functionality to be in the first version. I can add it to pyyeelight directly, or I can add it to my utility, but if I do the latter I doubt I'll have time to do the former later on...

I don't really mind either way, so it's up to you, but I'd be happy to submit a PR for this now if you want. Otherwise, we can revisit it later. Thanks for your efforts!

from pyyeelight.

HydrelioxGitHub avatar HydrelioxGitHub commented on July 22, 2024

I think your idea is an enhancement for this library so please PR !

I will merge it and push it to pypi at the end of the next week. When I will be back at home from my trip.

from pyyeelight.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.