GithubHelp home page GithubHelp logo

Comments (4)

hynek avatar hynek commented on September 28, 2024

Yeah and I may do the API differently if I designed it today. But can you imagine what would happen if:

  1. I changed the API from raising an exception to returning False? (free entry on all existing installations)
  2. Had one API that raises and error and one API the returns False? (people would keep mixing it up leading to free entry on some installations)

TBH I cannot find a responsible way to make you happy without introducing a high probability of security vulnerabilities due to changing/inconsistent APIs.

from argon2-cffi.

ranisalt avatar ranisalt commented on September 28, 2024

I have an idea. You can (and probably should) keep the exceptions BUT you could raise a different exception on verification failure. Users may proceed differently on mismatch or other failuer type.

from argon2-cffi.

hynek avatar hynek commented on September 28, 2024

Yeah I planned a VerificationError sub-class WrongSecretError or whatever that gets caught along as before but allows for finer grained handling.

from argon2-cffi.

hynek avatar hynek commented on September 28, 2024

Fixed in e7aaa80.

from argon2-cffi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.