issue with marked.js#0.3.5 about angular-marked

[johnwebbcole]

I'm seeing this as well. 0.3.3 works, 0.3.4 does not. No errors other than the markdown source is rendered inside a single <p> tag.

[ascholz81]

I see this as well. Marked 0.3.3 works well, but 0.3.5 has issues.

Currently I'm using it for mainly headings.
"##My Heading"
With v0.35 I have to change the string to "## My Heading"

[ascholz81]

My issue was resolved by the marked project owner. Marked was not following GFM correctly. They have updated to requiring a space after the # for headings.

[leoli-dev]

@ascholz81 Did marked.js release the new version yet?

[Hypercubed]

@ajielee @johnwebbcole The new version of marked requires a space after the hashes (markedjs/marked#642). Is this your issue?

[Hypercubed]

@ajielee Why do you have a $scope.$watch statement in your example? If you are using the directive you don't need to call marked directly.

[leoli-dev]

@Hypercubed Yes, that's the reason why I got the problem. But I don't agree with the GFM style, so I still hold marked.js#0.3.3. Thank you.

[leoli-dev]

@Hypercubed Sorry for that block of code, which I forgot to delete.

[Hypercubed]

@chjj recommends:

marked.Lexer.rules.gfm.heading = marked.Lexer.rules.normal.heading;

You might be able to do something like this using the setRenderer method.

[chjj]

GFM does not support headings such as: "##heading". Only the original markdown implementation does. Like @Hypercubed mentioned, either overwrite the rules or use gfm: false.

If we were to change the GFM rules to accept headings like that, there would be another camp of people posting issues about incohesiveness with GFM, unfortunately. Personally, I don't think it's a big deal, but we're trying more to stick to GFM, however inconvenient it may be.