GithubHelp home page GithubHelp logo

Comments (7)

Hypercubed avatar Hypercubed commented on June 3, 2024

Hmm.... I think something is missing from your message.

from angular-marked.

kalyanvgopal-zz avatar kalyanvgopal-zz commented on June 3, 2024

Sorry. I updated my original post.

from angular-marked.

Hypercubed avatar Hypercubed commented on June 3, 2024

Sounds resionable. Maybe add a error callback here: https://github.com/Hypercubed/angular-marked/blob/master/lib/angular-marked.js#L311

PRs welcome.

from angular-marked.

Hypercubed avatar Hypercubed commented on June 3, 2024

On second thought... maybe best to add a onError callback? This callback can handle generating an error message.

<div marked src="vm.document" onError="showError($element)"> </div>

from angular-marked.

Hypercubed avatar Hypercubed commented on June 3, 2024

The ng-include directive dispatches an event on error: https://github.com/angular/angular.js/blob/master/src/ng/directive/ngInclude.js#L262

from angular-marked.

kalyanvgopal-zz avatar kalyanvgopal-zz commented on June 3, 2024

I made the pull request. Please provide your feedback.

from angular-marked.

Hypercubed avatar Hypercubed commented on June 3, 2024

Merged... thank you.

from angular-marked.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.