GithubHelp home page GithubHelp logo

Comments (3)

onmyway133 avatar onmyway133 commented on May 30, 2024

@andreyrd Hi, we have decided to not use UIWindow to frame, but instead using view of presented ViewController, which is LightBoxController. You can check https://github.com/hyperoslo/Lightbox/releases/tag/2.1.0

from lightbox.

andreyrd avatar andreyrd commented on May 30, 2024

Hey, thanks! But it looks like it's still being used as a default value for size in the configureLayout method signature, now at this line LightboxController:274.

It looks like this size defines the frame of the scroll view, and if I don't implement UIApplicationDelegate.window, my scroll view stays at size zero.

from lightbox.

onmyway133 avatar onmyway133 commented on May 30, 2024

@andreyrd It shouldn't depend on the size of the UIWindow, since it's presented view controller. I can fix that, or do you want to submit a PR 😉 ?

from lightbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.