GithubHelp home page GithubHelp logo

Comments (7)

onmyway133 avatar onmyway133 commented on May 31, 2024

@jsntfv Hi, does it happen for you in the demo app? I don't see the problem

simulator screen shot - iphone x - 2017-11-22 at 09 38 23

from lightbox.

jsntfv avatar jsntfv commented on May 31, 2024

Hi @onmyway133,
I am using Xcode 9.2 beta. I tried the demo app and got the same result in the iPhone X simulator. Then I tried Xcode 9.1 and that is when I found out the difference between iOS11.1 and iOS11.2. I consistently have the footer view missing with devices on iOS11.2 but not on iOS11.1
But if I rotate the device, the footer view appears when using iOS11.2. I hope this helps.

from lightbox.

onmyway133 avatar onmyway133 commented on May 31, 2024

@jsntfv I'm not using beta so I don't know, but I will wait for the final version of 9.2, then I will check

from lightbox.

jsntfv avatar jsntfv commented on May 31, 2024

Thank you

from lightbox.

annjawn avatar annjawn commented on May 31, 2024

I am facing the same issue. Infact in my case the footer view briefly shows up when the Close button is tapped.

from lightbox.

annjawn avatar annjawn commented on May 31, 2024

I think this issue needs to be re-opened @onmyway133 ... I had to finally do this y: view.bounds.height - footerView.frame.height - 100 in LightBoxController.swift for the footer view to show up. Otherwise, the footerview is showing up but it's too low in the scrollview that it's not even visible. I might change the 100 to a slightly smaller number for now. I updated to 2.1.1 but the problem still persisted.

open override func viewDidLayoutSubviews() {
    super.viewDidLayoutSubviews()

    scrollView.frame = view.bounds
    footerView.frame = CGRect(
      x: 0,
      y: view.bounds.height - footerView.frame.height - 100,
      width: view.bounds.width,
      height: 100
    )

    headerView.frame = CGRect(
      x: 0,
      y: 16,
      width: view.bounds.width,
      height: 100
    )
  }

from lightbox.

annjawn avatar annjawn commented on May 31, 2024

You know what...nevermind. I think it's a simulator bug. 😊 It works fine on the devices.

from lightbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.