Comments (10)
I am investigating this. Another anomaly here, unsure if related or not, is that location order is unexpected. Manu's convention is to annotate the title so his summary appears first in the default location-sorted sidebar.
But here -- https://hyp.is/z7ElAlqIEeaB4898VeRkKg/www.theguardian.com/environment/2016/aug/02/environment-climate-change-records-broken-international-report -- it doesn't. Instead https://hyp.is/92NkkllsEea8JIP9CV7biQ/www.theguardian.com/environment/2016/aug/02/environment-climate-change-records-broken-international-report appears first, but anchors to the caption of the image, several elements below the title.
from client.
Observations
- The badge reports 29 annotations, corresponding to the 29 public annotations visible at https://hypothes.is/api/search?limit=200&uri=https://www.theguardian.com/environment/2016/aug/02/environment-climate-change-records-broken-international-report
- The sidebar reports 26 annotations (with orphans-tab on: 25 annotations, 1 orphan)
- The sidebar contains 29 annotation cards
- There are 26 top-level annotations, 3 replies
- document.querySelectorAll('.annotator-hl'), in the document, finds 25 highlights, the missing one is 3A7KdFo-EeaVNa9aFa94Pg
- Several repros here -- https://docs.google.com/document/d/1HC48At3OVWrEcEWHTwUEx7B9M-8YO6ysf01SLmQW6OY -- which yield nothing conclusive but show that deleting either of two different annotations will clear the error.
from client.
TextPositionSelectors don't agree with TextQuoteSelectors
Compare these two annotations:
0hTyrlltEeaVA9fVSqEUdw
{
"type": "TextPositionSelector",
"end": 4446,
"start": 4417
},
{
"exact": "more than 50% of its surface.",
"prefix": "grate, experienced melting over ",
"type": "TextQuoteSelector",
"suffix": "\nThe rapid changes in the climat"
}
"text" : "Like posted above ... "
"user" : leneae101
S8_CyFo_Eea52vcs3J9AVg
{
"type": "TextPositionSelector",
"end": 4431,
"start": 4402
},
{
"exact": "more than 50% of its surface.",
"prefix": "grate, experienced melting over ",
"type": "TextQuoteSelector",
"suffix": "\nThe rapid changes in the climat"
}
"text": "This is true. .."
"user" : "twilamoon"
The TextQuoteSelectors matches exactly, the TextPositionSelectors have the same length (29) but are offset by about half that length.
from client.
See also hypothesis/h#3278
from client.
Fix anchoring error on Guardian Climate Change article
from client.
This is very likely related https://via.hypothes.is/http://www.newyorker.com/science/maria-konnikova/being-a-better-online-reader
from client.
Here's a diff between an annotation that anchors in that maria-konnikova article and one that doesn't:
I know we've suspected that overlapping annotations may be a factor in some of the problems we've been seeing, this seems to point in that direction.
In that case, btw, the result is the same in via and the extension.
from client.
But here is a minimal version of the above that does not exhibit the problem:
http://jonudell.net/h/anchoring/anchoring-01.html
from client.
I'll admit I'm grasping at straws, but here is a possibly useful clue. I created a simpler page at http://jonudell.net/h/anchoring/konnikova_03.html and programmatically recreated the above annotations using only TextQuoteSelector:
"selector": [
{
"exact": "The text you read on a Kindle or computer simply doesn\u2019t have the same tangibility.",
"prefix": "rmer grounding in the material. ",
"type": "TextQuoteSelector",
"suffix": " In new research that she and he"
}
and
"selector": [
{
"exact": "he text you read on a Kindle or computer simply doesn\u2019t have the same tangibility.",
"prefix": "mer grounding in the material. T",
"type": "TextQuoteSelector",
"suffix": " In new research that she and he"
}
]
That page exhibits the problem: one anchors, another does not.
Then, taking a copy of that page at http://jonudell.net/h/anchoring/konnikova_04.html, I made those annotations interactively.
In that case, both anchor as expected:
Could this be a compound/cascading thing where, if TextPositionSelector is messed up (for unknown reasons), then the fallback to TextQuoteSelector also fails for overlap-related reasons? (hypothesis/h#3278)
from client.
One other issue I saw on the Guardian article is then activating, de-activating and then re-activating the extension with v0.47.0 of the client:
Uncaught Error: duplicate define: jquery
at K (app.js:formatted:166)
at F (app.js:formatted:173)
at jquery:10269
at deletedIds (jquery:26)
at Object.require.jquery (jquery:38)
at s (_prelude.js:1)
at s (_prelude.js:1)
at _prelude.js:1
at Object.<anonymous> (annotator.js:2)
at Object.32.jquery (annotator.js:1956)
from client.
Related Issues (20)
- Can't annotate https://community.canvaslms.com/ (issue with tsParticles) HOT 2
- Validate max length for tags
- Error with iframe `allow` attribute when annotating pages on archive.org HOT 6
- Migrate to eslint flat config HOT 1
- Create a new toast-like notification that is displayed when there are pending updates HOT 2
- Add accessible `tabpanel` role to the panels handled by selection tabs in the sidebar
- Hide "annotate" and "highlight" icons from "Getting started" tab to screen readers
- Consider automatically closing the help panel if auto-opened and user creates annotations HOT 2
- Optionally preserve (carry over) tags for the ensuing annotation
- can't log in at Edge add-on HOT 7
- Multiple annotations by the same person have the same accessible title HOT 3
- Annotation cards can be interacted with the mouse but not with the keyboard
- Reconsider the usage of "dialogs" for non-modal sidebar panels
- When loading pending updates, consider scrolling to the "closest" one, not the latest one HOT 2
- Incorrect Conversion of Overlapping Highlights or Notes Upon Page Navigation HOT 5
- Adder not fully visible due to z-index miscalculation
- Chrome extension doesn't open H overlay on Reddit.com HOT 1
- Hypothesis expects Host in parent frame, not in any ancestor or top frame HOT 2
- Whenever an iframe changes location Hypothesis needs to be injected again HOT 2
- Mechanism for disabling creating annotations and displaying highlights on the host frame for enable-annotations iframe use cases HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client.