GithubHelp home page GithubHelp logo

Comments (4)

johnthagen avatar johnthagen commented on June 27, 2024 1

As noted at the bottom of https://stackoverflow.com/a/58051918, one (in my view big) differences between Django's native enumeration types and django-enumfield is that Django's returns a str when accessed rather than the actual Enum instance.

That means you can do the following in django-enumfields but not with Django Choices:

if my_model.color is Color.Red:
    ...

which is the preferred way to do type-safe Enum evaluation in Python.

With Django Choices you'd need to do something like:

if Color[my_model.color] is Color.Red:
    ...

or create a helper method for each Enum field to do this.

from django-enumfields.

jalaziz avatar jalaziz commented on June 27, 2024

Looking at the code, it seems like this package would actually work just fine with Django's enumeration types. About to test it out, but it might be good to provide examples that use Django's Choices class and its subclasses.

from django-enumfields.

johnthagen avatar johnthagen commented on June 27, 2024

Something I didn't realize the first time I read about the new Django 3.0+ enumeration types is that they are in fact "real" Python enums.

If you look at the Django source code:

class ChoicesMeta(enum.EnumMeta):
    """A metaclass for creating a enum choices."""

...

class Choices(enum.Enum, metaclass=ChoicesMeta):
    """Class for creating enumerated choices."""

They are really just Enums with some extra methods added onto them. My hesitation with using them when I first read about them is that it wasn't clear that they are truly Python Enums, so I preferred to stay with this package. But now that I know they are true Enums (not something that is totally Django-specific other than a few helper methods) I'm planning to move to them.

I hope this helps others who might have had a similar concern.

from django-enumfields.

johnthagen avatar johnthagen commented on June 27, 2024

I created a Django issue related to improving the docs in this area: https://code.djangoproject.com/ticket/33193

from django-enumfields.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.