Typescript performance regression about i18next

[felixmeziere]

Hi, we think we have found the culprit for this regression. It is linked with the ternary in FilterKeysByContext that gets evaluated all the time for no reason. We will work with our fix (that moves the ternary up and caches a value) for 2-3 weeks and report back here with a PR if everything works as expected!

[adrai]

I'm not a TS expert... not easy to make happy everyone...
Feel free to provide a PR...

[adrai]

#1883
#2042
#2091

[felixmeziere]

This has been preventing us from updating the library for a year as the types are unusable otherwise :(

[adrai]

Feel free to provide a PR if you know how this can be improved...
//cc @marcalexiei

[marcalexiei]

As always, for this kind of issues, a minimal reproduction example would be helpful.

BTW I don’t know if something more can be done to improve memory usage, so if anyone has some ideas a PR would be highly appreciated.

[felixmeziere]

This issue in the typescript repo mentions i18next a lot microsoft/TypeScript#53087 and is the exact problem we have. What explodes between previous versions of i18next and this is the number of type instantiations and memory usage (from `tsc -d --diagnostics).

I've tried to reproduce the conditions of my repo in a new repo but didn't succeed : it could be due to a lot of different things. Only thing I know is that with i18next version pre-v23 tsc runs like a charm but crashes after that...

[felixmeziere]

Here is what seems to do the trick in the meantime in case someone wants to have a look master...GreenGoTech:i18next:master

[marcalexiei]

@felixmeziere you can open the PR now if you wish, so we can test you patch against the current types test

[felixmeziere]

I'll open it as draft without comments or anything then

[marcalexiei]

A fix with the issue of memory usage has been added via #2166 and is available in v23.11.0