2.3.4 - 'RangeError [ERR_UNKNOWN_MODULE_FORMAT]: Unknown module format: undefined' about esmock

[iambumblehead]

Let's use this. If problems are still there for we could completely revert things back to 2.3.3 state and publish as 2.4.0

format: context.format === 'commonjs' ? 'commonjs' : 'module',

[iambumblehead]

for now, 2.3.5 is closer to the original 2.3.3 but still gives the 'commonjs' needed for the issue resolved by 2.3.4

// 2.3.3
format: 'module',
// 2.3.4
format: context.format,
// 2.3.5
format: context.format === 'commonjs' ? 'commonjs' : 'module',

[tommy-mitchell]

Maybe module could be used as a fallback? e.g.

format: context.format ?? 'module',

[koshic]

Maybe module could be used as a fallback? e.g.

format: context.format ?? 'module',

Sure, it solves the issue - but not the root cause. Why do we expect anything in 'context.format'? Other loaders / Node default loader may resolve module format, may not. Only esmock has knowledge about files with urls like 'file:///Users/xxxxxxxx/packages/create-request/src/create-request.ts?esmk=1'

PS Yes, I checked my ts-loader - I don't set any format for .ts files if they are imported via relative urls inside 'resolve' hook, it's responsibility of 'load' hook (valid behaviour according to docs). Node default resolver do nothing for .ts file too. And because esmock placed into chain after ts-loader and due to 'shortCircuit: true' here

esmock/src/esmockLoader.js

Line 150 in 35ada4d

shortCircuit: true,

ts-loader just have no ability to pass proper format next (== to Node default loader).

[iambumblehead]

oh no I'm sorry everyone

[iambumblehead]

npm won't let me unpublish it

[iambumblehead]

[email protected] is published

[iambumblehead]

@koshic I agree with your comments and am interested to try removing "format" altogether. I don't remember why it is used and it could be something that was used for node 12 or node 14 which esmock did support but there was a problem with npm that forced us to drop node 14 from the test matrix