Comments (9)
I ran into something similar recently, and didn't have time to dig into it. I'm stuck in a cabin on a mountain right now, but on monday I'll be back in civilization, and would be happy to help debug and fix. If you want to do some remote pair programming on it let me know, and we can share a screen session or something.
from etsy.
That sounds cool. If you want to switch places, a cabin in the mountain sounds incredible. Send me a message whenever, I'd be happy to help if I can. In the meantime, I've just done the OAuth verification using the regular ol' oauth gem, which so far seems to be working.
from etsy.
I've committed a fix for this. Let me know if you run into any issues with it.
from etsy.
Hey awesome! I'll check it out and see how it goes, thanks for working on it! :-)
from etsy.
I just wanted to mention that I'm still seeing some issues with the etsy gem holding on to oauth tokens too long and giving them to the wrong person, so I'm going to be going through this with a fine-tooth comb in the next couple of days.
from etsy.
Katrina, do you have steps to reproduce this? I could take a stab at it this weekend as well.
from etsy.
Yepp, using this gist: https://gist.github.com/791872
This is what I did:
- From localhost:4567 click 'authorize', and log in to etsy as PaisleyAnnHome
- Click to view profile, and see 'logged in as PaisleyAnnHome'
- Go back to localhost:4567, click 'authorize'
- At etsy, switch to different user (circuit) and authorize
- Click to view profile
=> Expected to see 'logged in as circuit', but saw 'logged in as PaisleyAnnHome'.
from etsy.
This is what I found: on line 124 of lib/etsy.rb we memoize the access token, thus giving the calling code back the previous client, regardless of the request token/secret that is being passed in.
We could probably check an existing client against the request token and generate a new client if the tokens don't match, but this time around I'm simply clearing out the @access_token at the same time as the @verification_request when someone starts a new verification against etsy.
from etsy.
After thinking about this a little longer, I decided to always ask for a new client if asking for an access token, so that it generates the access tokens based on the request tokens passed in, rather than any memory of what has gone before.
from etsy.
Related Issues (20)
- Getting Listings for one section HOT 3
- Developers at Etsy? HOT 3
- 400 Error on New Listing HOT 5
- Grabbing results count HOT 1
- When gettting shop listings variations are empty HOT 2
- Is anyone working on updates for new version of API? HOT 3
- CI is failing, jruby this time HOT 2
- Why does Listing#variations require secure? HOT 4
- Store and Reuse an AccessToken? HOT 2
- Send PUT requests payload with the request body and not as query params HOT 5
- I am transferring ownership of this repository
- Migrating to Open API v3 HOT 3
- Is this gem supports Etsy V3 APIs? HOT 5
- User.shop throws a NilClass error without code change
- Etsy V2 API support ended HOT 1
- rubygems.org out of date HOT 3
- Listing.find_all_by_shop_id() throws error with state=sold HOT 3
- Failed to upload image: 400 Bad Request HOT 10
- Image API HOT 1
- Very High Memory Usage HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from etsy.