GithubHelp home page GithubHelp logo

Comments (6)

kytrinyx avatar kytrinyx commented on August 18, 2024

These methods generally operate on either a single identifier, or a list of identifiers.

self.find(*identifiers)
  # ...
end

Do you want to split these into two methods, for example
Etsy::Shop.find('reagent', options)
and
Etsy::Shop.find_all(['reagent', 'littlejane'], options)
?

Or is there a way to combine them (other than passing in the options first, which just seems dirty)?

from etsy.

reagent avatar reagent commented on August 18, 2024

I don't think the signature needs to change, though it's probably a good idea to change identifiers to something else (identifiers_and_options perhaps?). Since we'll always be dealing with an array of arguments, we could always inspect the type of the last parameter. If it's a hash, we can remove it from the list of identifiers and pass that as an option.

from etsy.

kytrinyx avatar kytrinyx commented on August 18, 2024

Excellent, I'll give that a whirl.

from etsy.

reagent avatar reagent commented on August 18, 2024

BTW, I merged v2 in with master and pushed out a gem yesterday (I'll post to the mailing list tonight). Just commit your changes into master when you're ready.

from etsy.

kytrinyx avatar kytrinyx commented on August 18, 2024

I went with the identifiers_and_options approach, and pushed it up to master.

from etsy.

kytrinyx avatar kytrinyx commented on August 18, 2024

This has been implemented (see the readme for details).

from etsy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.