GithubHelp home page GithubHelp logo

Comments (2)

skogsmaskin avatar skogsmaskin commented on May 18, 2024

Hi! I'm unable to reproduce this and determine if this is a regression caused by #5527.

The following test passes:

   test('can call ReactEditor.focus in hook', async () => {
     const editor = withReact(createEditor())
     const initialValue = [{ type: 'block', children: [{ text: 'test' }] }]
     const loadedValue = [{ type: 'block', children: [{ text: 'another test' }] } as Descendant]

     const TestComponent = () => {
       useEffect(() => {
         editor.children = loadedValue
         editor.onChange()
         ReactEditor.focus(editor)
       }, [])
       return (
         <Slate editor={editor} initialValue={initialValue}>
           <Editable />
         </Slate>
       )
     }

     await act(async () => {
       render(<TestComponent />)
     })

     expect(editor.selection).toEqual({"anchor": {"offset": 0, "path": [0, 0]}, "focus": {"offset": 0, "path": [0, 0]}})
     expect(editor.children).toEqual(loadedValue)
   })
 })

Also, similar code modifying the plaintext example also works fine here in a real browser (Chrome on MacOS).

from slate.

philicious avatar philicious commented on May 18, 2024

Thx @skogsmaskin for testing.
I'll do more testing myself to pin down the problem.

However, We started seeing this problem with release of #5542 but that should be reverted in 0.101.0

Major difference I see in your test is that you have an initial value set while we have an empty one

from slate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.