GithubHelp home page GithubHelp logo

Comments (7)

ibab avatar ibab commented on May 5, 2024

There's a bug in how the arguments are handled. I've fixed this as part of #88.

from tensorflow-wavenet.

jyegerlehner avatar jyegerlehner commented on May 5, 2024

OK thx ibab. I'll check that #88 fixes it, and if so close the issue.

from tensorflow-wavenet.

ibab avatar ibab commented on May 5, 2024

Adding biases to the fast generation is also quite easy. I could do that next.

from tensorflow-wavenet.

jyegerlehner avatar jyegerlehner commented on May 5, 2024

Is it? The thought crossed my mind when I saw it there and was putting in Xavier init, but I didn't understand all that black magic so didn't want to touch it. Better you than me. :)

from tensorflow-wavenet.

ibab avatar ibab commented on May 5, 2024

I've added biases (and tests) to the fast generation in #88.

from tensorflow-wavenet.

jyegerlehner avatar jyegerlehner commented on May 5, 2024

@ibab Is #88 meant to be backward compatible with existing checkpoint files? I did a naive merge and tried to generate, and got errors about tensor size mismatch. First dimension 1 vs. 2. Batch size change?

I'm guessing to test this branch I need to restart training from scratch and use that model to generate from.

from tensorflow-wavenet.

ibab avatar ibab commented on May 5, 2024

@jyegerlehner: I've just realized that this was an indication of the bug that I needed to fix :D
Generating with biases should be working now, so I'm closing the issue.

from tensorflow-wavenet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.