are we going to specific nodejs version in CONTRIBUTING.md? about blockchain-vscode-extension

[SamYuan1990]

and then, I am fail to

yuanyi@yuanyideMacBook-Pro blockchain-vscode-extension % lerna run compile       
lerna notice cli v5.0.0
lerna info Executing command in 7 packages: "npm run compile"
lerna ERR! npm run compile exited 1 in 'ibm-blockchain-platform-ui'
lerna ERR! npm run compile stdout:

> [email protected] compile
> rimraf build && npm run build


> [email protected] build
> cp ../blockchain-extension/ExtensionCommands.ts ./src/ExtensionCommands.ts && ./scripts/build-non-split.js && tsc -p tsconfig.json

lerna ERR! npm run compile stderr:

There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.

The react-scripts package provided by Create React App requires a dependency:

  "babel-loader": "8.1.0"

Don't try to install it manually: your package manager does it automatically.
However, a different version of babel-loader was detected higher up in the tree:

  /Users/yuanyi/OpenSource/blockchain-vscode-extension/packages/blockchain-ui/node_modules/babel-loader (version: 8.2.5) 

Manually installing incompatible versions is known to cause hard-to-debug issues.

If you would prefer to ignore this check, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That will permanently disable this message but you might encounter other issues.

To fix the dependency tree, try following the steps below in the exact order:

  1. Delete package-lock.json (not package.json!) and/or yarn.lock in your project folder.
  2. Delete node_modules in your project folder.
  3. Remove "babel-loader" from dependencies and/or devDependencies in the package.json file in your project folder.
  4. Run npm install or yarn, depending on the package manager you use.

In most cases, this should be enough to fix the problem.
If this has not helped, there are a few other things you can try:

  5. If you used npm, install yarn (http://yarnpkg.com/) and repeat the above steps with it instead.
     This may help because npm has known issues with package hoisting which may get resolved in future versions.

  6. Check if /Users/yuanyi/OpenSource/blockchain-vscode-extension/packages/blockchain-ui/node_modules/babel-loader is outside your project directory.
     For example, you might have accidentally installed something in your home folder.

  7. Try running npm ls babel-loader in your project folder.
     This will tell you which other package (apart from the expected react-scripts) installed babel-loader.

If nothing else helps, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That would permanently disable this preflight check in case you want to proceed anyway.

P.S. We know this message is long but please read the steps above :-) We hope you find them helpful!

lerna ERR! npm run compile exited 1 in 'ibm-blockchain-platform-ui'
lerna WARN complete Waiting for 2 child processes to exit. CTRL-C to exit immediately.

[jt-nti]

The vscode extension is stuck on some very old versions (vscode 1.40.0 and node 10), which seems to be causing build failures as well now. Jumping straight to the latest versions might cause other things to break after this long so I'll try and t least get to node 12 in PR #3156. I've also created a draft PR #3156 to update the contributing guide depending on how that goes.

[SamYuan1990]

The vscode extension is stuck on some very old versions (vscode 1.40.0 and node 10), which seems to be causing build failures as well now. Jumping straight to the latest versions might cause other things to break after this long so I'll try and t least get to node 12 in PR #3156. I've also created a draft PR #3156 to update the contributing guide depending on how that goes.

Hi @jt-nti , it looks good to me for a fix nodejs version. and by fixing nodejs version, we can also fix node module version as https://www.npmjs.com/package/node-sass for example.

for node-sass we may need 4.12+ ?
Node 12 | 4.12+ | 72

and it seems we need to check other modules if build failure.

[jt-nti]

See #3183