Comments (10)
Hi,
By this change several test-cases which automatically clone pslse:master broke. This might not affect us alone but also other users doing this type of testing. I suggest that if changes are done, they should be done if possible in a backwards compatible manor. Also setting and environment
variable before the compile and letting the compile break in the middle if it is not set is not optimal. If you do not get around those env variables, you could add some preprocessor checks and print a more meaningful message e.g.
#ifndef CONFIG_BLABLA
#error "Please set CONFIG_BLABLA before you start compiling this code"
#endif
Best would be of course dropping to a default which ensures backwards compatibility.
I support what Joerg said before, introducing multiple env vars with conflict potential
is not a good idea.
Thanks
Frank
from pslse.
I got a complaint message as follows:
Hallo Frank,
...
ibcxl.c: In function '_psl_loop':
libcxl.c:1127: warning: unused variable 'op2'
libcxl.c:1127: warning: unused variable 'op1'
libcxl.c:1123: warning: unused variable 'function_code'
libcxl.c:1123: warning: unused variable 'op_size'
libcxl.c: In function '_pslse_connect':
libcxl.c:1499: error: 'PSLSE_VERSION_MAJOR' undeclared (first use in this function)
libcxl.c:1499: error: (Each undeclared identifier is reported only once
libcxl.c:1499: error: for each function it appears in.)
libcxl.c:1500: error: 'PSLSE_VERSION_MINOR' undeclared (first use in this function)
make: *** [libcxl.o] Error 1
Mit freundlichen Grüßen / Kind regards
And that is not my code ...
from pslse.
Please use release tag v3.1 to avoid this issue for the time being
from pslse.
@LanceThompson we went back to tag=v3.1, but we also see, that you made changes in master to revert the last weeks change. But master still needs the variable PSL8=1 in order to succesfully compile. Uma made changes in branch=capi2 to have one variable PSLVER=8|9 instead of two. She also added a msg in case this variable is not set. Both is not implemented in master or not reverted back to a state, where no variable is needed.
As our customers need a clear directive, please tell us, what you plan for branch=master, and when this change is available
from pslse.
Hi @joergkayser . We're going to leave master as is for the next 2 week approximately, if that is ok. We are all going to be out on holiday soon and just felt it would be better to leave it stable. As I mentioned, to avoid all the churn, remain on tag v3.1. When I tried to revert the merge, it didn't appear to work, so I didn't want make matters worse. If you want to keep using the new code, you can use the capi2 branch. In January, we will merge capi2 into master again and it will have the single env var PSLVER.
from pslse.
Thanks. I notify our users to take v3.1 for the moment and keep this ticket open, until master works again
from pslse.
@LanceThompson Please state (for our customers as well), how much longer we should stay on v3.1 for POWER8 applications. For a merged functionality on the master branch we need to document the additional environment variable PSLVER=8/9 or notify the user to stay on tag=v3.1, one or the other.
Please advise
from pslse.
We are getting asked from our users again and again, how long they have to stay on v3.1 instead of working with the master branch. Please provide a new schedule.
Thanks
from pslse.
We merged capi2 into master (again) a week or so ago. It seems like it has been ok. Is it ok to close this?
from pslse.
I am running fine with master on both P8 and P9 platforms. Thanks
from pslse.
Related Issues (20)
- Plenty of warnings in new version HOT 5
- Thread safety: mmio read and write keep lock when being interrupted by pthread_cancel() HOT 1
- Robustness: Add timeouts to loops HOT 1
- Cache Behavior of CAPI in PSLSE HOT 1
- rename top.v to top.sv
- PSLSE for CAPI 2.0 HOT 2
- Change hdx_cpl_laddr implementation from 10 bits to 7 bits HOT 1
- Track # of outstanding DMA rd/wr requests from AFU and print out ERROR message when limit is exceeded
- Add support for handling DMA reads w/addresses that are 64B aligned HOT 1
- request to limit interface to the psl9d implementation
- PSLSE does not cover all command Translation orderings "ahX_cabt" supported by PSL
- Buffer write valid "haX_bwvalid" only driven twice?
- An improper locking bug(e.g., deadlock) on the lock HOT 2
- Debug messages: Please reduce verbosity HOT 1
- Underlinkage: libcxl.so is underlinked and does not show libpthread using ldd HOT 1
- PSLSE for CAPI2.0 not allow a br_lat value of 2 HOT 2
- PSLSE for CAPI2.0 not responding with REORDER_PERCENT != 0 HOT 2
- Symver patch forgotten in CAPI-2 version HOT 2
- Wrong Warning about ah_brlat HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pslse.