replace BaselineClassifier/Regressor by DummyClassifier/Regressor about lale

[tanmaygaikwad]

Thanks @hirzel for reporting the issue. I'll be working on it and assigning it to myself, starting with https://github.com/IBM/lale/blob/c8ec39b5a9118de89db46c8d2dffb62fb57d1d71/CONTRIBUTING.md

[hirzel]

Sounds great :) looking forward to your PR!

[tanmaygaikwad]

Hi @hirzel Is there any way either we can connect or I can connect with any existing member from lale team to assist me creating PR.
I have added DummyClassifier into lale.lib.sklearn but many pre-commit checks are failing which is not allowing me to commit and raise a PR.

Failing pre-comiit checks are not because of my codechange but even checking out master and empty-commit shows these check failures.

Few failing checks are

➜  lale (test) ✗ git commit -m "pre-commit check"
Check for case conflicts.................................................Passed
Check for merge conflicts................................................Passed
Debug Statements (Python)................................................Passed
isort....................................................................Passed
black....................................................................Passed
yamllint.............................................(no files to check)Skipped
flake8...................................................................Passed
mypy.....................................................................Passed
pyright..................................................................Failed
- hook id: pyright
- exit code: 1

No configuration file found.
stubPath /Users/mayankgaikwad/work/codes/python/open-source/lale/typings is not a valid directory.
Assuming Python platform Darwin
Searching for source files
Found 677 source files
/Users/mayankgaikwad/work/codes/python/open-source/lale/build/lib/lale/helpers.py
  148:43 - error: "int" is not a known member of module (reportGeneralTypeIssues)
  148:65 - error: "int" is not a known member of module (reportGeneralTypeIssues)
  151:25 - error: "int" is not a known member of module (reportGeneralTypeIssues)
  152:25 - error: "int" is not a known member of module (reportGeneralTypeIssues)
  153:25 - error: "int" is not a known member of module (reportGeneralTypeIssues)
  798:52 - error: "bool" is not a known member of module (reportGeneralTypeIssues)
/Users/mayankgaikwad/work/codes/python/open-source/lale/build/lib/lale/operators.py
  343:43 - error: Argument of type "Operator" cannot be assigned to parameter "op" of type "Operator" in function "to_json"
    "Operator" is incompatible with "Operator" (reportGeneralTypeIssues)
  365:41 - error: Argument of type "Operator" cannot be assigned to parameter "lale_operator" of type "Operator" in function "to_graphviz"
    "Operator" is incompatible with "Operator" (reportGeneralTypeIssues)
  421:13 - error: Argument of type "Operator" cannot be assigned to parameter "arg" of type "Dict[str, Any] | Operator" in function "to_string"
    Type "Operator" cannot be assigned to type "Dict[str, Any] | Operator"
      "Operator" is incompatible with "Dict[str, Any]"
      "Operator" is incompatible with "Operator" (reportGeneralTypeIssues)
  4258:52 - error: Argument of type "CustomizeOpType" cannot be assigned to parameter "op" of type "IndividualOp" in function "validate_method"
    "IndividualOp" is incompatible with "IndividualOp" (reportGeneralTypeIssues)
/Users/mayankgaikwad/work/codes/python/open-source/lale/build/lib/lale/datasets/data_schemas.py
  126:16 - error: Operator "==" not supported for types "Type[ndarray]" and "Type[ndarray]"
    Operator "==" not supported for types "Type[ndarray]" and "Type[ndarray]" (reportGeneralTypeIssues)
/Users/mayankgaikwad/work/codes/python/open-source/lale/build/lib/lale/datasets/openml/openml_datasets.py
  737:48 - error: "int" is not a known member of module (reportGeneralTypeIssues)
  739:46 - error: "int" is not a known member of module (reportGeneralTypeIssues)
/Users/mayankgaikwad/work/codes/python/open-source/lale/build/lib/lale/lib/aif360/disparate_impact_remover.py
  114:81 - error: Cannot access member "columns" for type "ndarray"
    Member "columns" is unknown (reportGeneralTypeIssues)
/Users/mayankgaikwad/work/codes/python/open-source/lale/build/lib/lale/lib/aif360/protected_attributes_encoder.py
  212:28 - error: Cannot access member "iloc" for type "NDArrayWithSchema"
    Member "iloc" is unknown (reportGeneralTypeIssues)
  220:31 - error: Cannot access member "columns" for type "NDArrayWithSchema"
    Member "columns" is unknown (reportGeneralTypeIssues)
  222:52 - error: Cannot access member "columns" for type "NDArrayWithSchema"
    Member "columns" is unknown (reportGeneralTypeIssues)
  226:57 - error: Cannot access member "index" for type "NDArrayWithSchema"
    Member "index" is unknown (reportGeneralTypeIssues)
  230:57 - error: Cannot access member "index" for type "NDArrayWithSchema"
    Member "index" is unknown (reportGeneralTypeIssues)
  250:35 - error: Cannot access member "index" for type "NDArrayWithSchema"
    Member "index" is unknown (reportGeneralTypeIssues)
  255:65 - error: Cannot access member "index" for type "NDArrayWithSchema"
    Member "index" is unknown (reportGeneralTypeIssues)
  259:33 - error: Cannot access member "apply" for type "ndarray"
    Member "apply" is unknown (reportGeneralTypeIssues)
    
    
    ...
    
    
    /Users/mayankgaikwad/work/codes/python/open-source/lale/test/test_autoai_libs.py
  122:14 - error: Import "autoai_libs.utils.fc_methods" could not be resolved (reportMissingImports)
  133:14 - error: Import "autoai_libs.utils.fc_methods" could not be resolved (reportMissingImports)
  147:14 - error: Import "autoai_libs.utils.fc_methods" could not be resolved (reportMissingImports)
  163:14 - error: Import "autoai_libs.utils.fc_methods" could not be resolved (reportMissingImports)
  181:14 - error: Import "autoai_libs.cognito.transforms.transform_extras" could not be resolved (reportMissingImports)
  195:14 - error: Import "autoai_libs.cognito.transforms.transform_extras" could not be resolved (reportMissingImports)
  196:14 - error: Import "autoai_libs.utils.fc_methods" could not be resolved (reportMissingImports)
/Users/mayankgaikwad/work/codes/python/open-source/lale/test/test_json_pretty_viz.py
  402:14 - error: Import "autoai_libs.transformers.exportable" could not be resolved (reportMissingImports)
  430:14 - error: Import "autoai_libs.transformers.exportable" could not be resolved (reportMissingImports)
  450:16 - error: Import "autoai_libs.cognito.transforms.transform_extras" could not be resolved (reportMissingImports)
  452:14 - error: Import "autoai_libs.cognito.transforms.transform_utils" could not be resolved (reportMissingImports)
  522:16 - error: Import "autoai_libs.cognito.transforms.transform_utils" could not be resolved (reportMissingImports)
  578:16 - error: Import "autoai_libs.cognito.transforms.transform_utils" could not be resolved (reportMissingImports)
  642:16 - error: Import "autoai_libs.utils.fc_methods" could not be resolved (reportMissingImports)
  644:14 - error: Import "autoai_libs.cognito.transforms.transform_utils" could not be resolved (reportMissingImports)
  728:14 - error: Import "autoai_libs.transformers.exportable" could not be resolved (reportMissingImports)
/Users/mayankgaikwad/work/codes/python/open-source/lale/test/test_relational.py
  20:10 - error: Import "pyspark" could not be resolved (reportMissingImports)
  21:10 - error: Import "pyspark.sql" could not be resolved (reportMissingImports)
167 errors, 0 warnings, 0 infos
Completed in 11.867sec

    ```

[shinnar]

Hi @tanmaygaikwad I am happy to assist. A few notes:

• there were some pre-commit errors recently due to changes in the linters. I just pushed a fix to master.
• what version of python are you using? I believe that we currently test/support python 3.6 and python 3.7. I am not sure if our linting currently works on python 3.8 or python 3.9.
• it also looks like you may want to import some more dependencies, such as autoai_libs. pip install '.[full]' should install them.
• Please read the comments I have left on the PR.
• I think we should move further interactions to the PR (unless they are more general design question about the issue)

Thanks for working on this issue!

[shinnar]

Closed by #644 .