Issue with rrule detecting last day of month when months are specified about ical4j

[benfortuna]

This is potentially fixed now as a result of PR #48.

[voronaam]

Actually, it is not fixed. After reading the RFC I am not sure what is the expected behaviour here. The problem is that there is one BYSETPOS and two others: BYMONTH and BYMONTHDAY. The author wanted BYSETPOS to apply to the BYMONTHDAY set, but in reality it gets applies to the overall list of candidate dates (selecting the last month in the list only).

RFC has it this way:

   If multiple BYxxx rule parts are specified, then after evaluating the
   specified FREQ and INTERVAL rule parts, the BYxxx rule parts are
   applied to the current set of evaluated occurrences in the following
   order: BYMONTH, BYWEEKNO, BYYEARDAY, BYMONTHDAY, BYDAY, BYHOUR,
   BYMINUTE, BYSECOND and BYSETPOS; then COUNT and UNTIL are evaluated.

I think the issue here is that BYMONTH rule evaluator breaks out of the FREQ=MONTHLY bound.

[benfortuna]

Ok I think this is now working as expected with the latest refactor of recurrence implementation.

For example, using the above rule for period 20150101/20170101 I get:

20150228
20150331
20150930
20151031
20160229
20160331
20160930
20161031

[voronaam]

Thank you. We will run a set of tests on our side.