ServiceLoader Action$Factory about ical4j

[benfortuna]

Hi,

There is a pre-built jar available here:

https://oss.sonatype.org/content/repositories/snapshots/org/mnode/ical4j/ical4j/2.0.0-bugfix-serviceloader-osgi-SNAPSHOT/

If you could let me know if you have success with it that would be
appreciated.

Regards,
Ben
On 29 Apr 2016 7:17 pm, "paphko" [email protected] wrote:

@benfortuna https://github.com/benfortuna Thank you for investigating
this issue. Do I have to re-build the ical4j lib from sources myself to get
the fix or is there somewhere a jar already available with that fix?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#64 (comment)

[paphko]

I get the same error when I build the org.openhab.io.caldav bundle from the current master branch and deploy it to a 1.8.2 runtime:

        at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:557) [quartz-all-2.1.7.jar:na]
Caused by: java.util.ServiceConfigurationError: net.fortuna.ical4j.model.PropertyFactory: Provider net.fortuna.ical4j.model.property.Action$Factory not a subtype
        at java.util.ServiceLoader.fail(ServiceLoader.java:239) ~[na:1.8.0]
        at java.util.ServiceLoader.access$300(ServiceLoader.java:185) ~[na:1.8.0]
        at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:376) ~[na:1.8.0]
        at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404) ~[na:1.8.0]
        at java.util.ServiceLoader$1.next(ServiceLoader.java:480) ~[na:1.8.0]
        at net.fortuna.ical4j.model.AbstractContentFactory.getFactory(AbstractContentFactory.java:85) ~[na:na]
        at net.fortuna.ical4j.model.PropertyFactoryImpl.createProperty(PropertyFactoryImpl.java:78) ~[na:na]
        at net.fortuna.ical4j.data.CalendarBuilder$ContentHandlerImpl.startProperty(CalendarBuilder.java:326) ~[na:na]
        at net.fortuna.ical4j.data.CalendarParserImpl$PropertyParser.parse(CalendarParserImpl.java:206) ~[na:na]
        at net.fortuna.ical4j.data.CalendarParserImpl$PropertyParser.access$1100(CalendarParserImpl.java:190) ~[na:na]
        at net.fortuna.ical4j.data.CalendarParserImpl$PropertyListParser.parse(CalendarParserImpl.java:173) ~[na:na]
        at net.fortuna.ical4j.data.CalendarParserImpl.parse(CalendarParserImpl.java:122) ~[na:na]
        at net.fortuna.ical4j.data.CalendarBuilder.build(CalendarBuilder.java:198) ~[na:na]
        at org.openhab.io.caldav.internal.job.EventReloaderJob.loadEvents(EventReloaderJob.java:299) ~[na:na]
        at org.openhab.io.caldav.internal.job.EventReloaderJob.loadEvents(EventReloaderJob.java:279) ~[na:na]
        at org.openhab.io.caldav.internal.job.EventReloaderJob.execute(EventReloaderJob.java:111) ~[na:na]
        at org.quartz.core.JobRunShell.run(JobRunShell.java:213) ~[quartz-all-2.1.7.jar:na]
        ... 1 common frames omitted

[benfortuna]

I'm currently testing a workaround to this issue, although ultimately I am now thinking using ServiceLoader may not have been the best decision. I will ultimately look for a solution that is more compatible with OSGi environments. Here is the pull request: #80

[paphko]

@benfortuna Thank you for investigating this issue. Do I have to re-build the ical4j lib from sources myself to get the fix or is there somewhere a jar already available with that fix?

[paphko]

@benfortuna Thanks, it works again!

[benfortuna]

Fixed for now, but will probably look at replacing ServiceLoader in future