Comments (5)
Good catch. I think the simplest way to resolve this is to just reference requestAnimationFrame
and cancelAnimationFrame
in the global scope instead of as a property of root
where the polyfill is defined. That will require a typeof
check though to avoid a ReferenceError
error if they don't exist. An alternative would be to get the actual global object like (0,eval)('this')
, but I think that's overkill.
from mainloop.js.
Actually, just referencing in the global scope won't work currently because the names requestAnimationFrame
and cancelAnimationFrame
get initialized in local scope before we can reference them. We would need either an earlier reference or a different local name. Instead I will just check on the window
object if it exists.
from mainloop.js.
@meeber Can you confirm this fix works? If so, I'll tag a new release so the fix can be pulled in more easily. Thanks!
from mainloop.js.
Confirmed: pure raf goodness with browserify. Thank you sir!
from mainloop.js.
1.0.3 released! Thanks for testing.
from mainloop.js.
Related Issues (20)
- Allow specifying a different requestAnimationFrame function HOT 6
- Deep call stack HOT 3
- Why not divide out framedelta by simulationtimestep to detect a panic sooner? HOT 1
- How I can avoid calling setEnd 60 times per second? HOT 2
- update() function always called with the same parametervalue HOT 1
- mainloop server-side not working because of "window" HOT 3
- Using a class method as function for "Update" or "Draw" HOT 2
- port to Rust / WASM HOT 2
- setInterval/setTimeout vs requestAnimationFrame? HOT 1
- Why does interpolation cycle? HOT 4
- Jank (esp in firefox) HOT 3
- Where is the good place to have Websocket send() calls with the library? HOT 2
- why such a big dip every few seconds in fps? HOT 1
- `update` step implementation question HOT 5
- Example that uses setBegin? HOT 2
- Update library to Node Module HOT 2
- Making loop run at an accelerated rate HOT 4
- links to docs from README are broken HOT 1
- The right way to use fps insensitive timeout or interval timers HOT 3
- I just wanted to say I love this project HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mainloop.js.