publish source tarball to pypi? about icloud_photos_downloader

[AndreyNikiforov]

It is there (icloudpd-1.17.4-py3-none-any.whl). You mos likely want to use default pip behavior that will download binary if it exists for the platform and fall back to src if needed. We have macos binary in pypi as well (icloudpd-1.17.4-py2.py3-none-macosx_11_0_x86_64.macosx_11_0_arm64.whl)

[chenrui333]

yeah, those are all wheels, I am looking for the source tarball

[AndreyNikiforov]

I don't think we ever provided src to pypi, only wheels. Src is available in github though:

Looking at the PR for homebrew, it seems that src from github were used before.

Is there any particular reason you want to use src, not binaries? Any reason you want zipped src vs wheels?

[chenrui333]

Looking at the PR for homebrew, it seems that src from github were used before.

yeah, the problem with github artifact is we dont have any mechanism to populate the dependency list.

[AndreyNikiforov]

yeah, the problem with github artifact is we dont have any mechanism to populate the dependency list.

Figuring out dependencies is challenging. We had a lot of issues reported related to dependencies until we switched to binary distribution.

BTW the failure in homebrew PR is in test expectation and icloudpd seems to be installed and running fine.

[chenrui333]

Figuring out dependencies is challenging. We had a lot of issues reported related to dependencies until we switched to binary distribution.

that is interesting, any pointer on that (sounds like requirements list issue?)

[chenrui333]

BTW the failure in homebrew PR is in test expectation and icloudpd seems to be installed and running fine.

yeah, just updated the test to ship this release.

[chenrui333]

relates to Homebrew/homebrew-core#172656

[AndreyNikiforov]

relates to Homebrew/homebrew-core#172656

What is the trigger for HB version bump? Should be github release IMO, and it is not yet available for v1.17.6.

[chenrui333]

What is the trigger for HB version bump?

there is autobump process that we are using.

[chenrui333]

same deal as this one, Homebrew/homebrew-core#172797

[AndreyNikiforov]

same deal as this one, Homebrew/homebrew-core#172797

What is the problem with this one? Seems to merged already.

[AndreyNikiforov]

What is the trigger for HB version bump?

there is autobump process that we are using.

I suspect that autobump checks repository for changes and pulls sources from GH release. It takes hr+ to build and publish icloudpd, so to avoid problems in future, it would be best for you to adjust autobump process to use GH releases instead of source code changes (for checks and for pulling sources).