Missing block notifications in ICON btp_extension's websocket endpoint: /block about goloop

[mksong76]

@bbist It's impossible to send WebSocket messages skipping some blocks according to the codes.

While it makes a message to send, it uses h variable in the loop.

goloop/server/wsblock.go

Line 76 in bb933e3

br.bn.Height = common.HexInt64{Value: h}

And it's increased at the following line

goloop/server/wsblock.go

Line 123 in bb933e3

h++

There are two breaks before sending messages, and all of them result in disconnection.
So, it prints blocks with proper heights until it's disconnected.

I think that it may come from other parts not by GOLOOP.

Please check yours more closely.

[bbist]

Thanks for your response @mksong-icon,

Yes. That is strange to note. Logically it shouldn't ever miss a notification. As it is hard to reproduce, I'm not sure how to move ahead with this.
What we've done in Relay for now is to check for the missing events and reconnect while logging the exact reason for reconnection. We'll run this in production and see if we observe such an incident. We'll get back if we face this again.