Old version of the Oculus Integration package about open-brush

[TimAidley]

The issue is that the Oculus license does not allow redistribution of all of the files in the integration.

[mikeage]

I just tried upgrading from 1.41.0 to 23.1, following the instructions at https://developer.oculus.com/documentation/unity/unity-import/?device=QUEST (though I skipped the deletion of a bunch of files that started with Oculus, although I did, obviously, delete Assets/Oculus) and it seems to work (it does create two new files that need to be added to .gitignore; Assets/Resources/OVRPlatformToolSettings.asset and Assets/Resources/OVRPlatformToolSettings.asset.meta). In a five minute test, everything seemed ok (note that I'm using Android SDK 29 rather than the 26 that's in master; I also have PR 18 merged locally).

I don't know enough to try doing anything new with this, but as a base, it looks like it's safe enough to try using the newer version.

[billyquith]

That's what I've been using too. I couldn't get 1.41 to work (missing HandState?).

[mikeage]

Ok, so maybe we should just update the README to say to use 23.1 (and update .gitignore). I've opened a PR, and maybe a few other people can test and confirm.

[fabio914]

I wonder if there's a way we can automate downloading this dependency from Oculus. Perhaps a simple script to download it and include it with the project (part of a "setup" script maybe?), then we could ensure that everyone is on the same version while developing/building and that this script will have be updated when we start using a new version.

[fabio914]

@billyquith I believe hand tracking wasn't part of that version, so potentially the project is already using objects from a newer version. It's important that we find a way to ensure that people are using the same versions of these dependencies.

[mikeage]

Automating the download (easy) and installation (umm....) would also be very helpful for doing CI at some point, but while I'm happy to write python code to help, I don't know enough Unity to do it. I'm not even clear if adding the package does anything besides adding Assets/Oculus files; maybe they can be tracked in source control?

[fabio914]

Yeah, having this in source control is another option.

[mikeage]

Ah, ok, that’s a blocker!

By any chance, do you know how to script the installation of a unity package?

[TimAidley]

The issue is we can't just http fetch it as you have to agree to T&C before downloading it. However, we could make a wizard that would detect if it is installed, and guide you through the process.

[mikeage]

Right, missed that. I'm not doing well here ;-)