GithubHelp home page GithubHelp logo

remove hard-code about e3-tools HOT 11 CLOSED

rizzoa avatar rizzoa commented on July 17, 2024
remove hard-code

from e3-tools.

Comments (11)

jeonghanlee avatar jeonghanlee commented on July 17, 2024

We have the endless loop if we define them. I think you can override them by RELEASE.local file, which git doesn't track down.

from e3-tools.

jeonghanlee avatar jeonghanlee commented on July 17, 2024

TemplateGenerator only generates a file, users should add the proper version of each modules or applications which match their goals. In addition, one can use *.local files in order to override that versions. Now, I set EPICS_BASE=7.0.3 and REQUIRE=3.1.0. That is the baseline for e3 now. I will close this issue. If you have more, please open another issues.

from e3-tools.

rizzoa avatar rizzoa commented on July 17, 2024

Hi,
that's fine, but since in any case before to create a template I have to load my EPICS env, with those two env variables the RELEASE file will have automatically the correct variables set, avoinding any mistake and the need to edit it if I have to work with another version of EPICS

from e3-tools.

jeonghanlee avatar jeonghanlee commented on July 17, 2024

Hmm, that is the interesting approach, but I need to understand how you work first clearly. I have few proposals in my mind, but it is better to discuss them more detail soon. So I re-open this issue until we agree with each other and we find the better way to handle your issue.

from e3-tools.

rizzoa avatar rizzoa commented on July 17, 2024

HI,
sure, you are welcome to come to my desk to discuss with me!

from e3-tools.

jeonghanlee avatar jeonghanlee commented on July 17, 2024

@rizzoa , I tried to add additional features in e3TemplateGenerator in order to meet your requests, the result is not the same as what I saw in your terminal. I've got the following error if I have the same RELEASE file which you have. Actually, that error is exactly what I expected as follows:

RELEASE:2: *** Recursive variable 'EPICS_BASE' references itself (eventually). Stop.

Please check the release_test branch 248581f, you can generate the e3-something with new and test option (-r), it will create the same RELESE file which you describe. And let me know what you get, if you find something wrong in the codes, you can freely to fix them as much as you want. Or simple let me know what you see and think also.

from e3-tools.

rizzoa avatar rizzoa commented on July 17, 2024

Hi Han,
you just miss a colon in the line. If you don't put it, the Makefile will not expand the env variable and then you get the error, you can fix by just doing this

EPICS_BASE := $(EPICS_BASE)

from e3-tools.

jeonghanlee avatar jeonghanlee commented on July 17, 2024

The branch was merged into master at fabeb5b. I confirmed your comment makes it works. Please spend your time to explain this feature to others in README.md soon. I close this issue.

from e3-tools.

rizzoa avatar rizzoa commented on July 17, 2024

HI @jeonghanlee please look at this
rizzoa@c38ba38
I guess you have to fix it

from e3-tools.

jeonghanlee avatar jeonghanlee commented on July 17, 2024

@rizzoa , in order to get the RELEASE file with "Environmental variables", you need to add -r option. If not, it generates the hard-code RELEASE file instead of the dynamic one. That function you changed is used to generate the fixed variables RELEASE file.

I don't remove the hard-code RELEASE file, but add an additional option to create RELEASE file with "environment variables", which you would like to get. Please run your commands such as
bash e3TemplateGenerator.bash -m your.conf -r
will generate what you want to get. Let me know what you can.

In addition, I may add the another case scenario in travis in order to check a new feature which you would like to achieve.

from e3-tools.

rizzoa avatar rizzoa commented on July 17, 2024

Hi Han,
perferct, sorry for the missunderstanding, I am closing the issue!
Thanks

from e3-tools.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.