Cannot stub methods on subject about spectator

[icy-arctic-fox]

Is Test mocked? I added a mock block and it started working.

Spectator.describe Test do
  mock Test do
    stub method2
  end

  describe "#method1" do
    it do
      expect(subject).to receive(:method2)

      subject.method1
    end
  end
end

[postmodern]

hmmm stubbing one or both methods doesn't seem to be working:

  describe "#~" do
    mock Chars::CharSet do
      stub :===
    end

    let(other) { "foo" }

    it "must call #===" do
      expect(subject).to receive(:===).with(other)

      subject =~ other
    end
  end

  1) Chars::CharSet#~ must call #===
     Failure: subject did not receive #===("foo") : Nil at spec/char_set_spec.cr:770 at least once with any arguments

       expected: At least once with any arguments
       received: 0 time(s)

[icy-arctic-fox]

Should be resolved in v0.9.40, can you verify?

[postmodern]

Confirmed it works on the original Test example.

Although having trouble with my Chars::CharSet example.

  describe "#~" do
    mock Chars::CharSet do
      stub :===
    end

    let(other) { "foo" }

    it "must call #===" do
      expect(subject).to receive(:===).with(other)

      subject =~ other
    end
  end

Produces:

  1) Chars::CharSet#~ must call #===
     Failure: subject did not receive #===("foo") : Nil at spec/char_set_spec.cr:770 at least once with any arguments

       expected: At least once with any arguments
       received: 0 time(s)

[postmodern]

Changing the stub syntax to stub ===(other) causes another odd compilation error:

In spec/char_set_spec.cr:6:9

 6 | let(char_range) { 'A'..'Z' }
           ^---
Error: wrong number of arguments for macro 'stub' (given 0, expected )

[icy-arctic-fox]

There's a combination of things going on here. Because of some syntactical things, === must be a symbol on the stub line. The arguments also have to be defined slightly different. The following works for me:

  class Matcher
    def =~(other)
      self === other
    end

    def ===(other)
      true
    end
  end

  describe Matcher do
    mock Matcher do
      stub :===, other
    end

    describe "#~" do

      let(other) { "foo" }

      it "must call #===" do
        expect(subject).to receive(:===).with(other).and_return(true)

        subject =~ other
      end
    end
  end

I had to add and_return(true) to the expect line because it returns nil if that clause isn't provided.

[postmodern]

Hmm getting a weird error:

  describe "#~" do
    mock Chars::CharSet do
      stub :===, other
    end

    let(other) { "foo" }
    let(return_value) { true }

    it "must call #===" do
      expect(subject).to receive(:===).with(other).and_return(return_value)

      expect(subject =~ other).to be(return_value)
    end
  end

There was a problem expanding macro 'stub'

Code in spec/char_set_spec.cr:6:9

 6 | let(char_range) { 'A'..'Z' }
           ^
Called macro defined in lib/spectator/src/spectator/mocks/stubs.cr:3:13

 3 | private macro stub(definition, *types, _file = __FILE__, _line = __LINE__, return_type = :undefined, &block)

Which expanded to:

 >  9 | __temp_438.mocks.record_call(self, __temp_440)
 > 10 | if (__temp_441 = __temp_438.mocks.find_stub(self, __temp_440))
 > 11 |   return __temp_441.call!(__temp_439) { previous_def }
                                                ^-----------
Error: there is no previous definition of '==='

[icy-arctic-fox]

I'm not sure why that's happening. I've tried (what I think you're working on) with this snippet and it works:

  describe "#~" do
    mock Chars::CharSet do
      stub :===, other : String
    end

    let(other) { "foo" }
    let(return_value) { true }

    it "must call #===" do
      expect(subject).to receive(:===).with(other).and_return(return_value)

      expect(subject =~ other).to be(return_value)
    end
  end

I added : String type restriction to match the original definition.

But with the code you posted, it compiles, but fails since the method isn't stubbed right (needs the String type restriction on other). Perhaps you can send along the code if this snippet doesn't work with what you have.

Sorry about all of this back and forth. The mock support in Spectator could certainly use some improvements.

https://gist.github.com/icy-arctic-fox/63e500c462107cf29ce1c6fb1d3b652c

[postmodern]

Aaaaah the : String constraint fixed it. Thanks!