Comments (9)
Seems a possible solution: https://stackoverflow.com/questions/15674422/unable-to-detect-why-qdialog-is-memory-leaking
from idarling.
I'm not mean to be offensive, but I wonder why we need to care about things like this?
IDArling and IDA aren't used in a large-scale or long-time running scenario, and memory leak for about several KB or MB or even ~10MB each time opening the settings window is quite acceptable, as no one will repeatedly open and close it.
I think we should focus on other main issues instead of this tiny mysterious memory leak
from idarling.
But I also suggest that we solve this issue when we already have a pre-release
from idarling.
Seems a possible solution: https://stackoverflow.com/questions/15674422/unable-to-detect-why-qdialog-is-memory-leaking
Nope. Not the source. But fixed:
def settingsActionTriggered():
- SettingsDialog(self._plugin).exec_()
+ if self._settingsDialog == None:
+ self._settingsDialog = SettingsDialog(self._plugin)
+ self._settingsDialog.exec_()
from idarling.
How did you confirm the memory leak? I read the documentation of QDialog::done
and it appears to me that setting the Qt::WA_DeleteOnClose
flag would be enough. Am I missing something?
from idarling.
How did you confirm the memory leak? I read the documentation of QDialog::done and it appears to me that setting the Qt::WA_DeleteOnClose flag would be enough. Am I missing something?
Open & close the settings menu using a script and monitor the memory usage ;)
from idarling.
Sorry for the late reply @SilverBut. I've tested your pull request #52 but I'm still seeing a memory leak. Even if the dialog is reused, memory usage increases every time I open and close it. In all of my testing, the singleton method appears to be equivalent to using Qt::WA_DeleteOnClose
.
from idarling.
Strange. The commit 2714069 should not create any more setting dialogues and its pages. Maybe it is not the dialog which is created for many times.
I may check it later. Kind of busy recently.
from idarling.
totally agree, just keep it in a corner of our head for when there will be no more issue :)).
from idarling.
Related Issues (20)
- Failed to install action OpenAction HOT 2
- High CPU usage HOT 13
- Will there be a release of IDArling anytime soon? HOT 1
- Notepad is not sync'ed HOT 1
- Marked locations not sync'ed HOT 1
- User Interrupt when running idapython script HOT 1
- Big database files are downloaded/uploaded to server very slow HOT 10
- Huge database is very slow on downloading/uploading
- After opening the IDB, the first call sdk decompile show error HOT 2
- Add missing hooks for IDA 7.2 HOT 1
- feature request: allow user to rename a project or database
- Allow user to delete a project or database
- feature request: syncing mark pages? HOT 1
- Documentation clarification HOT 1
- Open from server without closing previous idb crashes IDA HOT 2
- Debugging cause huge load on other clients
- How to generate a certificate for IDArling server and client?
- Big DB Upload/Download failes due to "MemoryError" HOT 1
- OverflowError: Error while calling Python callback <nav_colorizer> with IDA 7.3
- Support IDA 7.4 & Python 3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from idarling.